[
https://issues.apache.org/jira/browse/OFBIZ-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335635#comment-15335635
]
Gareth Carter commented on OFBIZ-7346:
--------------------------------------
setRollbackOnReturn fixed the actual issue, when a connection is returned to
the pool, dbcp will call rollback and an error is thrown because the connection
has already been committed (this is database driver throwing the error). It
calls rollback because of an issue with the cached state of autoCommit in dbcp
as noted in the description
setEnableAutoCommitOnReturn I believe is not required and may not have any
affect. But I observed autoCommit was being set to true at transaction commit
(can't remember source file/line) so setting it again when returning to the
pool is redundant
> connection pooling not working
> ------------------------------
>
> Key: OFBIZ-7346
> URL: https://issues.apache.org/jira/browse/OFBIZ-7346
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Gareth Carter
> Assignee: Jacques Le Roux
> Priority: Critical
> Attachments: DBCPConnectionFactory.patch
>
>
> Connection pooling does not seem to work. Connections are created fine but as
> the close() method is called (outside of transaction) or the transaction is
> committed the connections are closed to the db server and not returned to the
> pool.
> I believe the issue is with
> org.apache.commons.dbcp2.PoolableConnectionFactory passivateObject method.
> This will call rollback() when rollbackOnReturn is set to true even if the
> transaction is committed. This is because any connection wrappers extending
> org.apache.commons.dbcp2.DelegatingConnection cache autoCommit status. At
> some point, this cached autoCommit is different from the underlying
> connection autoCommit. The rollback() method will throw an exception and the
> connection is destroyed rather than put back to the pool
> Environment this has been tested on:
> ofbiz: rev 1725574 and latest trunk (as of 2016-06-14)
> db: postgresql 9.1
> jdbc driver: postgresql-9.3-1101.jdbc4
> os: linux and windows
> I have asked dev ml for others to check this with other dbs. Jacques has test
> with postgres but could not see this behaviour
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
