[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343728#comment-15343728
]
Ankush Upadhyay edited comment on OFBIZ-6576 at 6/22/16 5:36 AM:
-----------------------------------------------------------------
Thanks [~Peter Arnold] for reporting the issue and research notes.
I have also noticed the same issue and about to going to create JIRA ticket for
the same to provide the solution. But it seems instead of duplicating tickets I
am attaching the patch to provide the generic and correct fix for this issue.
Solution summary: If we did not find the product price on the variant level
then the system should lookup it on virtual level instead of returning the
error or skip the workflow.
[~Peter Arnold] The solution you adopting is not recommended solution, in that
case, you can't create sales tax adjustment anymore in system.
Please review the changes and let me know if anything else needs to be taken
care under this.
was (Author: ankush.upadhyay):
Thanks [~Peter Arnold] for reporting the issue and research notes.
I have also noticed the same issue and about to going to create JIRA ticket for
the same to provide the solution. But it seems instead of duplicating tickets I
am attaching patch to fix this issue.
Please review the changes and let me know if anything else need to be taken
care under this.
> Pricing error in Variant Products when setup with VAT-Tax and price set on
> Virtual Product
> ------------------------------------------------------------------------------------------
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
> Reporter: Peter Arnold
> Priority: Minor
> Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual-
> variant- products and the price is defined only on the virtual product and
> with "Tax in Price" set to "Y", its variants should inherit the set price
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product
> is added to the shopping cart. Currently sales-tax is added to the product
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo: CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 10000 (Or the Party ID corresponding to the
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200
> (Widgets)
> Product Category ID: 200
> From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
> Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
> Feature Type: Color
> Description: Red
> Update
> Create New Feature
> Feature Type: Color
> Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
> Choose T-Shirt Colors Category
> Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected
> press the Variants
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the
> created virtual
> product "T-Shirt":
> Default Price
> From Date: Now
> Price: 11.9
> Tax Percentage: 19
> Tax in price: Y
> Create
> List Price
> From Date: Now
> Price: 11.9
> Tax Percentage: 19
> Tax in price: Y
> Create
> Now the products should be visible in the E-Shop.
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product.
> On Default- and List- Prices add:
> - Tax Percentage: 19
> - Tax Authority Party (ID): 10000 (Or whatever ID corresponds to
> SII_CHL Party)
> - Tax Auth Geo Id: CHL
> Update
> Back in the E-Shop on the product display now the correct prices appear.
> I.E. 11.9 USD for the virtual product, the red, and the blue shirt.
> Now I preselect the blue T-Shirt and add 1 to the shopping cart.
> If I go to the cart now the price of the Blue T-Shirt is 14,16USD.
> Now let's define a product price directly on the Red T-Shirt variant product:
> Under Catalog Manager / Product select the product "T-Shirt Red".
> Under the Prices Tab:
> - Price Type: Default Price
> - From Date: Now
> - Price: 11.9
> - Tax Percentage: 19
> - Tax Authority Party (ID): 10000 (Or corresponding ID to SII_CHL)
> - Tax Auth Geo ID: CHL
> - Tax in Price: Y
> Create
> - Price Type: List Price
> - From Date: Now
> - Price: 11.9
> - Tax Percentage: 19
> - Tax Authority Party (ID): 10000 (Or corresponding ID to SII_CHL)
> - Tax Auth Geo ID: CHL
> - Tax in Price: Y
> Create
> Back to the E-Shop
> Select now the Red T-Shirt and add to shopping cart.
> If you check the prices in the shopping cart the red T-Shirt would be
> sold at 11.9 USD and the blue T-Shirt at 14.16USD.
> Only difference being that I have set up pricing directly on the Red
> T-Shirt, while the blue one gets its price from the virtual product T-Shirt.
> If you do the Quick Check out with a Chilean "Ship To" address and get to the
> "Final Checkout Review", you can see that for the Red T-Shirt no sales Tax is
> applied while for the blue one there is a sales tax of USD 2.26
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
