Hi Guys,
I'll be off for 2 days and I have not much time to comment. But I got an idea I think it's worth considering, though I did not yet get enough time to
investigate and check how to exactly include it in OFBiz.
Like we did a long due and good cleaning by moving Groovy and Freemarker files and will do with Gradle to have Junit tests separated from other Java
code, I think we should use http://requirejs.org/ to better organise our JavaScript files, snippets in Freemarker files and maybe even the external
JavaScript files currently all in images component. So we would have of best both worlds: clearly separated and grouped functions (easier development,
no big balls of mud) with production performance.
I'll get back to this later, please have it a thought in the meantime
Thanks
Jacques
Le 04/07/2016 à 10:40, Amardeep Singh Jhajj a écrit :
I agree Deepak,
We can split based on modules for example- autocompleter module, etc in
different files and it can be initialized from Util.js on page load (or any
other event). Makes complete sense.
And some of small utility functions like toggling can be in Util.js itself
and no need to create separate modules for it.
Thanks & Regards
--
Amardeep Singh Jhajj
On Mon, Jul 4, 2016 at 1:32 PM, Deepak Dixit (JIRA) <j...@apache.org> wrote:
[
https://issues.apache.org/jira/browse/OFBIZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360988#comment-15360988
]
Deepak Dixit commented on OFBIZ-1319:
-------------------------------------
I agree Jacques,
We can split files based on module, and can initialize them in util.js
to move further I think we can start with remaining selectall.js to
util.js to keep svn historty, and than we can move code into modules.
Split javascript files to have more generic ones includable in all
screens, and the more specific ones included more locally
----------------------------------------------------------------------------------------------------------------------------
Key: OFBIZ-1319
URL: https://issues.apache.org/jira/browse/OFBIZ-1319
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Minor
From a David's E. Jones comment on ML :
We should split up javascript files to have the more generic ones
includable in all screens, and the more specific ones (like the toggle* and
selectAll* methods in there) into a file that can be included more locally.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
