[ https://issues.apache.org/jira/browse/OFBIZ-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365979#comment-15365979 ]
Jacques Le Roux commented on OFBIZ-7297: ---------------------------------------- There is a small issue with this commit: ProductPromoOperatorEquality.PPC_EQ is used for 2 different labels, same for ProductPromoCondition.PPIP_PARTY_GRP_MEM > Migrate promotext.properties to UiLabels > ---------------------------------------- > > Key: OFBIZ-7297 > URL: https://issues.apache.org/jira/browse/OFBIZ-7297 > Project: OFBiz > Issue Type: Improvement > Components: product > Affects Versions: Trunk > Reporter: Mridul Pathak > Assignee: Mridul Pathak > Priority: Minor > Attachments: OFBIZ-7297-2.patch, OFBIZ-7297.patch > > > promotext.properties file is used only in > ProductPromoWorker.makeAutoDescription() method and was implemented way back > when UI Labels were managed in *.properties files. It should be moved to > UiLabels file because all the properties defined in the file are text > descriptions and not system configurations, which makes them a candidate of > internationalization. -- This message was sent by Atlassian JIRA (v6.3.4#6332)