Hello Everyone, Thank you for your feedback. I've created a JIRA and attached a patch to it that achieves what is discussed in this thread. Please feel free to review it before I commit. I moved the files containing the startup logic to the POS component so someone might reuse it if they want to.
https://issues.apache.org/jira/browse/OFBIZ-7924 Regards, Taher Alkhateeb On Fri, Jul 22, 2016 at 1:55 AM, Michael Brohl <michael.br...@ecomify.de> wrote: > After reading all comments on this proposal, I agree: +1 > > Michael Brohl > ecomify GmbH > www.ecomify.de > > Am 21.07.16 um 11:38 schrieb Taher Alkhateeb: > > Hello Everyone, >> >> This is a proposal to _remove_ the following commands from the OFBiz >> server >> (invoked with ./gradlew "ofbiz --commandHere" >> >> 1- --both >> 2- --pos >> 3- --testlist >> >> Reasons: >> - The POS component is a specialpurpose component and should not have code >> existing in the start component. Instead logic for starting the POS >> component should reside inside the POS component and away from framework >> - After lots of investigation I realized the testlist OFBiz command is a >> weird command that used to create an ant file that just iterates over the >> existing integration test suites and run them one by one, which is slower >> vs just running them all. It is deprecated and to my knowledge no one is >> using it. I think it used to serve some deprecated cobertura tasks. >> >> This would imply deleting the following files: >> - >> >> framework/start/src/main/java/org/apache/ofbiz/base/start/testlist.properties >> - >> >> framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestListContainer.java >> - >> >> framework/base/src/main/java/org/apache/ofbiz/base/splash/SplashLoader.java >> >> and modifying the following files: >> - framework/start/src/main/java/org/apache/ofbiz/base/start/Config.java >> - >> >> framework/start/src/main/java/org/apache/ofbiz/base/start/StartupCommandUtil.java >> - (move it to POS) >> >> framework/base/src/main/java/org/apache/ofbiz/base/splash/SplashScreen.java >> >> Agreed? >> >> Regards, >> >> > >
