On Tue, Aug 30, 2016 at 7:19 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Mmm, then who should fix it?
>

This is an opportunity for anyone reading your message to contribute.


> Of course I could have fixed it myself, but I thought that by providing an
> advice I'd help more.


Highlighting code that could be improved rather than fixing it is a good
way to help potential contributors.
However, and I think this is the reason for Scott's remark, you should not
have addressed your review/request to individual committer/contributor (if
the defect you have noticed was not introduced by their contribution, as in
this case).

Kind regards,

Jacopo


> As we say
>
> "If you give a man a *fish*, you have fed him for a day. If you teach a
> man to *fish*, you have fed him for a lifetime."
>
> Jacques
>
>
>

Reply via email to