Jacques this is still problematic, you are closing the streams upon exceptions! now all kinds of memory leaks and side effects could take place because you are not ensuring closing all streams properly.
This needs a revert and a full review to make things tight in terms of memory. On Fri, Sep 2, 2016 at 8:08 PM, Jacques Le Roux < [email protected]> wrote: > Le 02/09/2016 à 18:46, Jacopo Cappellato a écrit : > >> On Fri, Sep 2, 2016 at 3:19 PM, Jacques Le Roux < >> [email protected]> wrote: >> >> Le 02/09/2016 à 12:30, Jacopo Cappellato a écrit : >>> >>> ... >>>> >>> 2) I suspect that you are closing the socket connection too early >>> >>>> in PcChargeApi >>>> >>>> I see no problem with this point, the "sock" socket connection is not >>> used >>> in code below. >>> ... >>> Jacques >>> >>> >>> Jacques, >> >> at the moment I don't have time to explain but after your response above I >> am a bit concerned about the effort that you are carrying on, because you >> may break other code without even suspecting it. >> I have to go now, if others can explain then great, otherwise I will >> follow >> up with you asap. >> >> Jacopo >> >> Ah I think I got your point when back, I should better close the Socket > later, done at r1758990 > > Jacques > >
