Hi Jacopo, I cleaned OFBizSolrContextFilter.java and submitted in rev. 1759401. Please check if it's required to do a further refactoring.
Kind Regards, Shi Jinghai -----邮件原件----- 发件人: Shi Jinghai [mailto:huaru...@hotmail.com] 发送时间: 2016年9月6日 13:43 收件人: dev@ofbiz.apache.org 主题: Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ specialpurpose/solr/lib/ specialpurpose/solr/lib/compile/ s... Hi Jacopo, Let me clean the OFBizSolrContextFilter now. Kind Regards, Shi Jinghai -----邮件原件----- 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] 发送时间: 2016年9月5日 22:20 收件人: dev@ofbiz.apache.org 主题: Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ specialpurpose/solr/lib/ specialpurpose/solr/lib/compile/ s... Hi Jinghai, I have noticed that when you have committed the Solr component you have created a class named OFBizSolrContextFilter.java that is mostly the copy of ContextFilter: as a consequence the logic implemented in its utility methods has been duplicated. I didn't check, but it is possible that other code in this commit is affected by the same anti pattern. This is making the maintenance of the code more difficult: for example, I am in the process of cleaning/refactoring the code in ContextFilter and I am not sure how to deal with the same copy of it in OFBizSolrContextFilter. Is there anything you can do to fix this? Thank you, Jacopo On Sun, Aug 30, 2015 at 3:27 PM, <sh...@apache.org> wrote: > Author: shijh > Date: Sun Aug 30 13:27:07 2015 > New Revision: 1700119 > > URL: http://svn.apache.org/r1700119 > Log: > OFBIZ-5042 Apache Solr Implementation. > 1. Put the patch into trunk. > 2. Added access control to solr /admin/ pages. > 3. Upgraded solr to 4.9.0 to match Lucene version in trunk. > 4. Removed solr.solr.home, used > SolrResourceLoader loader = new SolrResourceLoader(" > specialpurpose/solr/conf"); > instead. > > Added: > ... ofbiz/trunk/specialpurpose/solr/src/org/ofbiz/solr/ > webapp/OFBizSolrContextFilter.java (with props) >
