No it doesn't. In fact it is completely off. Because the inclusion of the component name (MyComponent, in your reference) is nowhere required.
Unless I am misunderstanding you. Best regards, Pierre Smits ORRTIZ.COM <http://www.orrtiz.com> OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Wed, Sep 21, 2016 at 11:59 AM, gil portenseigne < gil.portensei...@nereide.fr> wrote: > In the commit for instance : > > title="${uiLabelMap.CommonDescription}" > > the MyComponent/Common explain both possible cases... > > Le 21/09/2016 à 11:52, Pierre Smits a écrit : > >> HI Gil, >> >> Where do you see "uiLabelMap.MyComponent/CommonXXXXX" in widgets and >> templates? Nowhere, as far as I can tell. But in each (most?) component >> you'll find >> {code}<property-map resource="CommonUiLabels" map-name="uiLabelMap" >> global= >> "true"/> >> {code} >> >> And for what it is worth: a product in manufacturing, accounting, party, >> workeffort or any other component referencing a product from the product >> component is a product. No difference in context. >> >> Best regards, >> >> Pierre Smits >> >> ORRTIZ.COM <http://www.orrtiz.com> >> OFBiz based solutions & services >> >> OFBiz Extensions Marketplace >> http://oem.ofbizci.net/oci-2/ >> >> On Wed, Sep 21, 2016 at 11:25 AM, gil portenseigne < >> gil.portensei...@nereide.fr> wrote: >> >> Hi Pierre, >>> >>> I do not agree that FormFieldTitle_XXX is *only* for lazy programmer (and >>> i remember a teacher that used to tell that to be good, you have to be >>> sma >>> rtly lazy :) ). >>> >>> The fact that this label contains default translation for XXX fields >>> allow >>> speed developpment and is far more readable than having >>> title="uiLabelMap.MyComponent/CommonXXXXX" everywhere in your form >>> file... And if you want to overload this label its very easy. I don't see >>> the problem here. >>> >>> inline >>> Le 21/09/2016 à 11:03, Pierre Smits a écrit : >>> >>> FormFieldTitle_XXX is for lazy programmers, only considering the OFBiz >>> Demo >>> implementation as the only adopter of the product. Who use >>> {code}<auto-fields-entity entity-name="EntityName" >>> default-field-type="XXXX" >>> />{code} >>> as their means to display entity elements (fields) in forms. >>> >>> Unfortunately that doesn't work for all. >>> >>> Furthermore, like I said inhttps://issues.apache.org/ji >>> ra/browse/OFBIZ-8121?focusedCommentId=15501193&page=com. >>> atlassian.jira.plugin.system.issuetabpanels:comment- >>> tabpanel#comment-15501193 >>> A specific title applied processes faster than none applied. >>> >>> How much ? For display i guess it's not significant. >>> >>> >>> Also, applying specific labels reduces the total number of labels, when >>> one >>> takes the context into consideration. >>> >>> Labels for products or others object could be different in each >>> component, >>> thus i don't like replacing all with CommonXXX >>> >>> Regards, >>> >>> Gil >>> >>> >>> E.g. >>> >>> CommonProduct >>> >>> vs >>> >>> AccountingProduct >>> >>> ManufacturingProduct >>> >>> OrderProduct >>> >>> WorkEffortProduct >>> PartyProduct >>> >>> FormFieldTitle_Product >>> >>> ScrumProduct >>> >>> EtcProduct >>> >>> >>> Best regards, >>> >>> Pierre Smits >>> ORRTIZ.COM <http://www.orrtiz.com> <http://www.orrtiz.com> >>> >>> OFBiz based solutions & services >>> >>> OFBiz Extensions Marketplacehttp://oem.ofbizci.net/oci-2/ >>> >>> >>> On Wed, Sep 21, 2016 at 9:47 AM, gil portenseigne < >>> gil.portensei...@nereide.fr> wrote: >>> >>> >>> Hi Jacques, >>> Like Nicolas said in previous Michael commit answer: >>> http://markmail.org/message/x4ulworuwgbotvrv?q=r1761332 >>> >>> I do not understand these kind of improvements. Adding a title when and F >>> ormFieldTitle_XXX properties exists is not good in my opinion (i did not >>> check these ones). >>> >>> Moreover i liked Michael answer on this JIRA : >>> https://issues.apache.org/jira/browse/OFBIZ-8056?focusedComm >>> entId=15501066&page=com.atlassian.jira.plugin.system. >>> issuetabpanels:comment-tabpanel#comment-15501066 >>> >>> Gil >>> >>> Le 21/09/2016 à 09:34, jler...@apache.org a écrit : >>> >>> Author: jleroux >>> Date: Wed Sep 21 07:34:13 2016 >>> New Revision: 1761687 >>> >>> URL: http://svn.apache.org/viewvc?rev=1761687&view=rev >>> Log: >>> Improves: Maximise the utilisation of common labels in various >>> applications >>> (OFBIZ-8110) >>> >>> There are many commonalities among entity field definitions. Often these >>> field >>> definitions have led to unique label definitions, where a shared >>> (common) label >>> could have sufficed. >>> >>> As examples you can take: >>> * the various Id fields (where for most label CommonId could be used) >>> * the various Type fields (where for most label CommonType could be used) >>> >>> This is a placeholder ticket, intended to capture applicable issues as >>> sub tasks >>> to address the aspect of maximising the utilisation of labels in the >>> CommonUiLabels.xml file and to track progress. >>> >>> Thanks: Pierre Smits >>> >>> Modified: >>> ofbiz/trunk/specialpurpose/myportal/widget/PortalAdmForms.xml >>> >>> Modified: ofbiz/trunk/specialpurpose/myportal/widget/PortalAdmForms.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/mypo >>> rtal/widget/PortalAdmForms.xml?rev=1761687&r1=1761686&r2= >>> 1761687&view=diff >>> ============================================================ >>> ================== >>> --- ofbiz/trunk/specialpurpose/myportal/widget/PortalAdmForms.xml >>> (original) >>> +++ ofbiz/trunk/specialpurpose/myportal/widget/PortalAdmForms.xml Wed >>> Sep 21 07:34:13 2016 >>> @@ -27,7 +27,7 @@ under the License. >>> <field name="originalPortalPageId" >>> position="2"><text-find/></field> >>> <field name="portalPageName" title="${uiLabelMap.CommonName >>> }"><text-find/></field> >>> <field name="parentPortalPageId" position="2"><text-find/></fie >>> ld> >>> - <field name="description"><text-find/></field> >>> + <field name="description" title="${uiLabelMap.CommonDesc >>> ription}"><text-find/></field> >>> <field name="securityGroupId" position="2" >>> title="${uiLabelMap.CommonSecurityGroupId}"><text-find/></field> >>> <field name="searchButton" title="${uiLabelMap.CommonFind}" >>> widget-style="smallSubmit"><submit button-type="button"/></field> >>> </form> >>> @@ -88,8 +88,8 @@ under the License. >>> <text/> >>> </field> >>> <field name="parentPortalPageId" position="2"><text/></field> >>> - <field name="portalPageName"><text/></field> >>> - <field name="description" position="2"><text size="60"/></field> >>> + <field name="portalPageName" title="${uiLabelMap.CommonName >>> }"><text/></field> >>> + <field name="description" title="${uiLabelMap.CommonDescription}" >>> position="2"><text size="60"/></field> >>> <field name="sequenceNum"><text/></field> >>> <field name="securityGroupId" > >>> <drop-down allow-empty="true"> >>> >>> >>> >>> >>> >>> >>> >>> >>> >
