Since nobody answered, I will remove it in few days as a lazy consensus

Jacques


Le 03/10/2016 à 13:16, Jacques Le Roux a écrit :
Hi Ashish,

At r1763154 I did all the similar trivial changes.

To All, Adam,

I wonder about keeping this code put in in 2008 with 
http://svn.apache.org/viewvc?view=revision&revision=713573

/**
 * Finds product variants based on a product ID and a distinct feature.
 */
public static Map<String, Object> prodFindDistinctVariants(DispatchContext dctx, 
Map<String, ? extends Object> context) {
    // * String productId      -- Parent (virtual) product ID
    // * String feature        -- Distinct feature name
    //TODO This service has not yet been implemented.
    return ServiceUtil.returnFailure();
}

Jacques


Le 17/09/2016 à 13:26, Jacques Le Roux a écrit :
Hi Ashish,

I think we lose some information here


Le 17/09/2016 à 12:34, ash...@apache.org a écrit :
      public static Map<String, Object> prodFindDistinctVariants(DispatchContext 
dctx, Map<String, ? extends Object> context) {
-        // * String productId      -- Parent (virtual) product ID
-        // * String feature        -- Distinct feature name
          //TODO This service has not yet been implemented.
          return ServiceUtil.returnFailure();
      public static Map<String, Object> prodMakeFeatureTree(DispatchContext dctx, 
Map<String, ? extends Object> context) {
-        // * String productId      -- Parent (virtual) product ID
-        // * List featureOrder     -- Order of features
-        // * Boolean checkInventory-- To calculate available inventory.
-        // * String productStoreId -- Product Store ID for Inventory
          String productStoreId = (String) context.get("productStoreId");
          Locale locale = (Locale) context.get("locale");
  @@ -352,9 +340,6 @@ public class ProductServices {
       * Gets the product features of a product.
       */
      public static Map<String, Object> prodGetFeatures(DispatchContext dctx, 
Map<String, ? extends Object> context) {
-        // * String productId      -- Product ID to find
-        // * String type           -- Type of feature (STANDARD_FEATURE, 
SELECTABLE_FEATURE)
-        // * String distinct       -- Distinct feature (SIZE, COLOR)
          Delegator delegator = dctx.getDelegator();
          Map<String, Object> result = new HashMap<String, Object>();
          String productId = (String) context.get("productId");
@@ -386,7 +371,6 @@ public class ProductServices {
       * Finds a product by product ID.
       */
      public static Map<String, Object> prodFindProduct(DispatchContext dctx, 
Map<String, ? extends Object> context) {
-        // * String productId      -- Product ID to find
          Delegator delegator = dctx.getDelegator();
          Map<String, Object> result = new HashMap<String, Object>();
          String productId = (String) context.get("productId");
@@ -407,15 +391,10 @@ public class ProductServices {


      public static Map<String, Object> prodFindAssociatedByType(DispatchContext 
dctx, Map<String, ? extends Object> context) {
-        // * String productId      -- Current Product ID
-        // * String type           -- Type of association (ie PRODUCT_UPGRADE, 
PRODUCT_COMPLEMENT, PRODUCT_VARIANT)

Thanks!

Jacques





Reply via email to