Looks very wrong to me. Two different type sets should not be just copied over. While we're at, it might be better to rewrite this in Java or Groovy
On Feb 10, 2017 11:05 AM, "Paul Foxworthy" <p...@cohsoft.com.au> wrote: > Hi all, > > As you might guess if you've been looking at Jira and the dev list lately, > I've been working on purchases and sales generating GL transactions. > > Please have a look at the createAcctgTransForPurchaseInvoice method in > applications/accounting/minilang/ledger/GeneralLedgerServices.xml > > line 2024 in trunk does this: > > <set field="debitEntry.glAccountTypeId" > from-field="invoiceItem.invoiceItemTypeId"/> > > Wat? > > There are two different sets of values defined in two different places for > invoice item types and GL account types. Surely you can't just copy a value > from one to the other? Shouldn't there be a service right here to find a > decent GL account type based on the invoice item type? > > Later on, the getGlAccountFromAccountType service looks at all sorts of > things to decide the final GL account to use. But the GL Account *type* is > an input to that. > > Am I missing something, or is this a very nasty bug? > > Thanks > > Paul Foxworthy > > -- > Coherent Software Australia Pty Ltd > PO Box 2773 > Cheltenham Vic 3192 > Australia > > Phone: +61 3 9585 6788 > Web: http://www.coherentsoftware.com.au/ > Email: i...@coherentsoftware.com.au >
