+1

On Feb 18, 2017 8:16 AM, "Ratnesh Upadhyay" <upadhyay.ratn...@gmail.com>
wrote:

+1 for the initiation, also we can enforce it as best practice for future
implementations and patches.

Thanks!!

Regards,
Ratnesh Upadhyay
HotWax Systems
www.hotwaxsystems.com

On Mon, Jan 9, 2017 at 2:52 PM, Devanshu Vyas <vyas.devansh...@gmail.com>
wrote:

> Hello Devs,
>
> I found an inconsistency in the code for string comparison
> *statusId.equals("PRUN_COMPLETED")* whereas it should be written as
> *"PRUN_COMPLETED".equals(statusId)*
> cause the former can throw NullPointerException if the variable found to
be
> NULL.
>
> This code pattern can be found at several places and if you all agree with
> this I can provide a patch for correcting code.
>
> Let me know your thoughts.
>
> Thanks & Regards,
> Devanshu Vyas.
>



--
--
----------------------------------------------------
Cheers,
Thanks and Regards,
Ratnesh Upadhyay
Senior Business Analyst (Enterprise Software Solutions)
HotWax Media, Inc.
http://www.hotwaxmedia.com
----------------------------------------------------
E-mail : ratnesh.upadh...@hotwaxmedia.com
Mobile : +919826886909

Reply via email to