I'd expect that as a committer you would follow all Jiras and even all Jira 
comments not only those you are interested

Moreover you were the one who introduced this issue

http://ofbiz.markmail.org/search/?q=dependsOn+%22%3Aplugins%3A%24%7BpluginId%7D%3Ainstall%22

So I'd expect you to care more about it

Thanks for r1791168 anyway

Jacques


Le 12/04/2017 à 19:48, Taher Alkhateeb a écrit :
I cannot follow up with every single JIRA, also, I assume if you commit
code then you know what you're doing.

On Wed, Apr 12, 2017 at 8:38 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

Also I'd have expected that you had commented in the Jira before!

Why wait the commit?

Jacques



Le 12/04/2017 à 19:35, Jacques Le Roux a écrit :

Please explain more or point to links where it's already explained

Thanks

Jacques


Le 12/04/2017 à 18:54, Taher Alkhateeb a écrit :

This commit is completely wrong and poorly thought and does not fix the
root cause.

Please revert

On Wed, Apr 12, 2017 at 7:38 PM, <jler...@apache.org> wrote:

Author: jleroux
Date: Wed Apr 12 16:38:59 2017
New Revision: 1791143

URL: http://svn.apache.org/viewvc?rev=1791143&view=rev
Log:
Fixed: The createTenant Gradle task fails
(OFBIZ-9273)

Problem:
When you enter
bq. gradlew createTenant -PtenantId=test
you get
FAILURE: Build failed with an exception.
* Where:
Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
* What went wrong:
A problem occurred evaluating root project 'ofbiz'.

Could not get unknown property 'pluginId' for task ':installAllPlugins'

of
type org.gradle.api.DefaultTask.

Investigation:
This issue is due creation of build.gradle file in plugin (with empty
gradle
task defined in it)

Solution:
Comment out build.gradle template content

Thanks: Deepak for confirmation, Swapnil M Mane for the investigation
and
patch

Modified:
ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle

Modified: ofbiz/ofbiz-framework/trunk/framework/resources/templates/
build.gradle
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
framework/resources/templates/build.gradle?rev=1791143&r1=
1791142&r2=1791143&view=diff
============================================================
==================
--- ofbiz/ofbiz-framework/trunk/framework/resources/templates/bu
ild.gradle
(original)
+++ ofbiz/ofbiz-framework/trunk/framework/resources/templates/bu
ild.gradle
Wed Apr 12 16:38:59 2017
@@ -1,3 +1,4 @@
+/*
   dependencies {
       //Examples of compile-time and runtime dependencies

@@ -16,3 +17,4 @@ task uninstall {
           // uninstall logic for this plugin
       }
   }
+*/






Reply via email to