+1 Better think about it a bit more, maybe encourage the contributor to provide a more generic solution instead of letting half-done code into the codebase. It will be there for long.
Best regards, Michael > Am 19.04.2017 um 13:54 schrieb Jacopo Cappellato > <jacopo.cappell...@hotwaxsystems.com>: > > On Wed, Apr 19, 2017 at 3:36 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >> To be clear: my question is not about applying only 1 VAT, we already >> apply several. But as explained in OFBIZ-9255 to fix an issue in a special >> case which, for now, would be fixed only when 1 percentage is applied. > > > My general advice is to avoid as much as possible to commit fixes for > special cases that don't work for more general cases because the proper > solution to address the more general case may be significantly different > from the solution for the specific case fix and this adds complexity to the > codebase that needs to be addressed at a later point of time. > > Jacopo
