OK the 2nd test issue is fixed with r1798086 where I reverted my changes in
ListFinder.java
But as noted in the commit comment I have to check all is correct with current
code.
Is the created EntityListIterator always closed (in all cases) is still obscure
to me.
Maybe it's not a big deal because it's caught in EntityListIterator.finalize(),
but still.
Jacques
Le 08/06/2017 à 15:49, Jacques Le Roux a écrit :
Hi Taher,
This is my bad, let me explain why I missed it. I use to rely on Buildbot. Last
trunk message was OK https://s.apache.org/Uz5M
But I completely forgot that we still need to update our Buildbot config. And actually we still rely on
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins
I just fixed the PerformFindTests.getCompleteList(). I'll take care of the testClearAddressMatchMap failure and will completely review our Builbot
config!
Jacques
Le 08/06/2017 à 14:31, Taher Alkhateeb a écrit :
Hey Folks,
I have 2 failing tests in the system:
- party-tests.testClearAddressMatchMap (Failure)
- testPerformFind (Error)
So whoever committed this code please look into fixing it. Also let's agree
that at a minimum tests should pass with ./gradlew cleanAll loadDefault
testIntegration before committing?
Cheers,
Taher Alkhateeb
