+1 Michael
Am 10.07.17 um 07:03 schrieb Taher Alkhateeb:
Historically the data loader boolean props are false if ommitted and the code expects that, but you have a point about the double negative. We can instead call it "continue-on-failure" for example. On Jul 10, 2017 3:48 AM, "Paul Foxworthy" <p...@cohsoft.com.au> wrote: Hi all, I agree with option 3. I recall in my own work I once needed to add a throw where there was none to track down a problem. However ignore-failure leads to a double negative. How about "stop-on-failure", default value true? Cheers Paul Foxworthy On 10 July 2017 at 05:27, Taher Alkhateeb <slidingfilame...@gmail.com> wrote:Correction: on item (2) in my post: fail immediately, not after loading all files, otherwise there's no point. On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb <slidingfilame...@gmail.com> wrote:Hello Everyone, For a long time I was annoyed by something in OFBiz: the build system does not fail if data loading fails for some files. I spend hours hunting bugs only to discover that the data simply did not load. Given that I'm working on refactoring the data loading container, I believe this issue should resolved. However, I'm not sure if the community is interested in making such a change. So I list below 3 options to select from: 1- Leave it as is, do not fail the build if some files do not load 2- Continue loading until all files are done and then fail the build 3- Provide a flag e.g. ignore-failure that tells the system whether to fail or not with a default value of "false". My personal preference is for (3) WDYT?-- Coherent Software Australia Pty Ltd PO Box 2773 Cheltenham Vic 3192 Australia Phone: +61 3 9585 6788 Web: http://www.coherentsoftware.com.au/ Email: i...@coherentsoftware.com.au
smime.p7s
Description: S/MIME Cryptographic Signature