Hi Fabio, see my comments below.
Stephan On 03.04.14 14:04, "Fabio Martelli" <[email protected]> wrote: >Il 03/04/2014 13:31, Klevenz, Stephan ha scritto: >> Hi Fabio, >> >> The issue for fit module is gone and it is ok now. >> >> The client core still has an issue with this inside the pom: >> >> <testResource> >> <directory>${basedir}/../../fit/src/main/resources</directory> >> <filtering>true</filtering> >> </testResource> >> >> You are right, this is not a cyclic dependency but more a dependency >> outside the module tree which Eclipse doesn't like. I'll take this just >>as >> a problem we should get solved somehow. >> >> What I currently not get is the role of fit module. In odata2 we >> differentiated between plain JUnit tests which were close to the code >> (src/test/java) and integration tests which were JUnit tests as well but >> just more complex because they did setup a server and run scenarios over >> http. The latter we bundled in a module we called fit. >> >> What I see now is that integration tests are part of the client core and >> the fit module does not contain tests. >> >> So, we have a different understanding of what the fit module is. Can you >> please explain how you see the role of fit module and integration tests >>at >> all? >Hi Stephan, I've just one requirement: I need to run a pseudo/static >server in order to test the client library. >I've no particular needs to keep integration tests tight to client-core >module. So I would like to propose just to move only integration tests (org.apache.olingo.client.core.it.*) plus their resources to the fit module. Standard junit test can remain in client.core. As consequence the dependency between fit and client will change. Afterwards fit will depend on client. Client module will stay independent with no dependencies to integration testing stuff. If we haven an agreement on this then I will open an issue. > >Actually, I had some doubts when provided static server into fit (the >name "fit" sounds a little bit strange for our purpose). >What do you suggest? >> >> It would be great if we could get a common understanding where client >>code >> and server code can both do integration testing in the same way. > >Currently, I have difficulty to imagine client and core performing >integration tests in the same way but may be I'm missing something. >If you think that a refactoring is needed, please can you open a new >issue with sufficient details? I expect that we get a first server prototype within one of our next development cycles. Then we have the same requirement as you, which means we want to start our server using failsave, cargo and run also unit tests over http. In best case we can combine your client and our server. This is a discussion we can have at a later point. > >Thank you in advance. >Best regards, >F. > >> >> Greetings, >> >> Stephan >> >> >> >> On 03.04.14 11:01, "Fabio Martelli" <[email protected]> wrote: >> >>> Hi Stephan, I've just committed the back dependency. >>> Please, try out and let me know. >>> >>> Best regards, >>> F. >>> >>> Il 03/04/2014 10:19, Klevenz, Stephan ha scritto: >>>> Hi, >>>> >>>> I am having issues in setting up my OData 4 project using eclipse >>>>maven >>>> plugin (mvn eclipse:eclipse). Actually the module fit and client core >>>>do >>>> show errors. >>>> >>>> I have analyzed two reasons for that: >>>> >>>> a) cyclic dependencies >>>> >>>> Fit depends on client core and vice versa. Q: Can we avoid this e.g. >>>>by >>>> moving all testing stuff from client core to the fit module? Later, I >>>> think we do the same with server based integration tests. >>>> >>>> b) additional resources outside the hierarchy >>>> >>>> Fit module for instance references to root dir for getting its license >>>> file. Can we avoid this root reference e.g. by having a copy task >>>>where >>>> the root publish its sources to sub module? >>>> >>>> Eclipse as IDE is very strict in hierarchies and allows only top down >>>> dependencies. On the other hand it's not bad to keep sub module >>>> independent. >>>> >>>> WDYT? >>>> >>>> Greetings, >>>> Stephan >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> -- >>> Fabio Martelli >>> >>> Tirasa - Open Source Excellence >>> http://www.tirasa.net/ >>> >>> Apache Syncope PMC >>> http://people.apache.org/~fmartelli/ >>> > > >-- >Fabio Martelli > >Tirasa - Open Source Excellence >http://www.tirasa.net/ > >Apache Syncope PMC >http://people.apache.org/~fmartelli/ >
