[ 
https://issues.apache.org/jira/browse/OLINGO-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966283#comment-13966283
 ] 

Michael Bolz commented on OLINGO-239:
-------------------------------------

Hi Gerben,

I had to change a little more so that your fix works also for loading of 
classes within JAR files in paths with spaces.
Can you please check if current SNAPSHOT version (commit id: 
{{e1b6ead92c2bb71055e99cc9f762e4bccbd96974}}) work for you and if it do please 
close this issue.

Kind regards,
Michael 

> ClassHelper doesn't find classes when there's a space in the path
> -----------------------------------------------------------------
>
>                 Key: OLINGO-239
>                 URL: https://issues.apache.org/jira/browse/OLINGO-239
>             Project: Olingo
>          Issue Type: Bug
>          Components: odata2-annotation
>    Affects Versions: V2 1.2.0
>            Reporter: Gerben Kegel
>            Assignee: Michael Bolz
>            Priority: Trivial
>
> When you have space in your path and ask the ClassHelper to loadClasses(...), 
> it doesn't find anything. The problem is because an URL class is used where 
> the space converted to a %20. This URL does not point to a file anymore.
> Please call the following function (using .toUri().getPath()) to fill 
> fqnForClasses in line 71.
> {{
> private static Collection<String> getFqnForClasses(String packageToScan, URL 
> url, FilenameFilter ff) {
>         try {
>             File folder = new File(url.toURI().getPath());
>             if (folder.isDirectory()) {
>                 return getClassFqnFromDir(ff, folder, packageToScan);
>             } else if (isJarFile(url)) {
>                 return getClassFqnFromJar(url.getFile().substring(5), 
> packageToScan);
>             }
>         } catch (URISyntaxException ex) {
>         }
>         return null;
>     }
> }}
> Thank you



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to