[ 
https://issues.apache.org/jira/browse/OLINGO-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997582#comment-13997582
 ] 

Felipe Taiarol commented on OLINGO-283:
---------------------------------------

Hi Chandan,
A)      It is a matter of a few milliseconds, pretty fast.
B)      Evo will pretend it is English and it will try to show the plural.
C)       Apache License Version 2.0.

Follow attached the patch. I only changed the pom.xml to include the library 
and changed one line of code in the JPANameBuilder.

I totally agree with you, the mapping will still be necessary for language 
specific words. 

I just think that it would be better if the proposed word was already correct 
at least for English.

For example:
   I had in my model the following JPA entities. Passenger, Company, Bus and 
Route. 
  The OData entities created for that were, Passengers, Companys, Buss and 
Routes.

For sure I could create the XML Mapping to override the wrong names but it 
would be more convenient if they were already correct. Nobody likes to manage 
another XML configuration file :)

Also, English is the language most people use when writing software so I 
believe most part of the users would benefit from this change.

WDYT ?

Regards,
Felipe.


> Wrong OData Entities name from JPA
> ----------------------------------
>
>                 Key: OLINGO-283
>                 URL: https://issues.apache.org/jira/browse/OLINGO-283
>             Project: Olingo
>          Issue Type: Improvement
>          Components: odata2-jpa
>    Affects Versions: V2 1.3.0
>            Reporter: Felipe Taiarol
>            Assignee: Chandan V.A
>            Priority: Trivial
>              Labels: suggestion
>         Attachments: patch.zip
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When the OData entities are created from the JPA entities Olingo just adds an 
> ā€œsā€ at the end of the name. It would be nice if the correct plural was used 
> instead.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to