[
https://issues.apache.org/jira/browse/OLINGO-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115664#comment-14115664
]
Ramesh Reddy commented on OLINGO-417:
-------------------------------------
Here is the link to the .patch file
https://github.com/rareddy/olingo-odata4/commit/336f7d079eab5b52c632714124961adeb5870f03.patch
Here is the link to the .diff file
https://github.com/rareddy/olingo-odata4/commit/336f7d079eab5b52c632714124961adeb5870f03.diff
I can also submit a pull request, let me know.
> Expression visitor class is not flexibile
> -----------------------------------------
>
> Key: OLINGO-417
> URL: https://issues.apache.org/jira/browse/OLINGO-417
> Project: Olingo
> Issue Type: Improvement
> Components: odata4-server
> Reporter: Ramesh Reddy
>
> The current visitor frame work has couple drawbacks
> 1) The name of the methods should be "visitor" (just pet peeve)
> 2) It is not necessary that all the visitation methods can return same type
> of return value across the whole visitor class. In my scenario I am trying to
> build a SQL language object
> 3) The Expression object *must* not dictate the Expression navigation to
> visitor. The current way limits one way to walk the expression, not very
> flexible. It should be left out the visitor to walk the expression.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
