[ 
https://issues.apache.org/jira/browse/OLINGO-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14211990#comment-14211990
 ] 

Michael Bolz commented on OLINGO-193:
-------------------------------------

Hi [~lior.okman],

I pushed [your 
contribution|https://git-wip-us.apache.org/repos/asf?p=olingo-odata2.git;a=commit;h=dd98b32d395f51da7ab0c1eac194cd2e25f9ad6a]
 as well as some [minor code clean 
up|https://git-wip-us.apache.org/repos/asf?p=olingo-odata2.git;a=commit;h=ee0798736eaff71a377d704067032c3add145567]
 from my side in the feature branch.
Actual I have two points to note:
* For contributions to Apache it is necessary that each file has the _Apache 
License Header_ included.
* For new features and/or bugfixes we create a (JUnit) test to verify that 
according feature/bugfix works. Can you please add some test for the Spring 
extension.

Kind regards,
Michael

> Olingo on Spring implementation scenarion
> -----------------------------------------
>
>                 Key: OLINGO-193
>                 URL: https://issues.apache.org/jira/browse/OLINGO-193
>             Project: Olingo
>          Issue Type: New Feature
>          Components: odata2-core
>         Environment: Spring
>            Reporter: Jan Penninkhof
>            Assignee: Michael Bolz
>            Priority: Minor
>              Labels: spring
>         Attachments: move-up.diff, spring.diff
>
>
> Currently only a imlementation scenario using CXFNonSpringJaxrsServlet is 
> provided. However, to implement OLingo while bootstrapping Spring at the same 
> time, this scenario won't work. Instead probably CXFServlet should be used 
> instead.
> However, CXFServlet has quite a different API and Olingo currently doesn't 
> have wiring to that API.
> It would be excellent if there would be a version of Olingo that could work 
> in a Spring environment as well, e.g. to allow for reuse of existing Spring 
> components.
> Please also refer to a discussion on this topic in the mail-archive:
> https://www.mail-archive.com/[email protected]/msg02186.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to