[ 
https://issues.apache.org/jira/browse/OLINGO-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766432#comment-15766432
 ] 

Stefan Bodenstein commented on OLINGO-1063:
-------------------------------------------

Hi Michael,
the solution should be sufficient, althought double checked locking would be 
the technique suggested for this case.
By the way, is there any reason to use a late initialization here. 

Best Regards 

> Thread safetiness in 
> org.apache.olingo.odata2.core.edm.provider.EdmStructuralTypeImplProv
> -----------------------------------------------------------------------------------------
>
>                 Key: OLINGO-1063
>                 URL: https://issues.apache.org/jira/browse/OLINGO-1063
>             Project: Olingo
>          Issue Type: Bug
>          Components: odata2-core
>    Affects Versions: V2 2.0.7
>            Reporter: Stefan Bodenstein
>         Attachments: 161220_Olingo-1063.diff
>
>
> The method getPropertyNames in EdmStructuralTypeImplProv is not thread safe. 
> It potentially returns a non initialized list, which is modified while 
> iterating over it. This is not only theoretically, but already appeared in 
> our application. 
> Please make the method synchronized or synchronize the initialization of the 
> list unsing double checked locking.
> Best Regards 
> Stefan 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to