[
https://issues.apache.org/jira/browse/OLINGO-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598877#comment-17598877
]
varun_ramesh commented on OLINGO-1574:
--------------------------------------
Hi [~mirbo] ,
Thanks much for your time checking the patch file. I have checked the same and
the changes are fine. I have added one additional change in
ODataErrorResponseChecker. I have attached a new patch file with all the
changes in your PR along with this changeset and tested the same. Please review
the change in ODataErrorResponseChecker and proceed with the merge.
(In ODataErrorResponseChecker.checkResponse() we are parsing the response
payload to construct ODataError object. It involves jackson deserialization
hence the InputStream becomes empty after deserialization which is being set in
the exception object.)
[^0002-OLINGO-1574-Better-error-messages-for-client.patch]
Thanks & Regards,
Varun.
> ODataClientErrorException & ODataServerErrorException doesn't have the
> response body
> ------------------------------------------------------------------------------------
>
> Key: OLINGO-1574
> URL: https://issues.apache.org/jira/browse/OLINGO-1574
> Project: Olingo
> Issue Type: Improvement
> Components: odata4-client
> Affects Versions: (Java) V4 4.9.0
> Reporter: varun_ramesh
> Assignee: mibo
> Priority: Major
> Attachments:
> 0001-OLINGO-1574-enhancement-for-getting-response-in-case.patch,
> 0002-OLINGO-1574-Better-error-messages-for-client.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When a OData backend service throws >= 400 error code
> ODataClientErrorException is constructed or if the service throws >= 500 HTTP
> status code Olingo constructs an ODataServerErrorException.
> This exception class doesn't hold the actual response returned by the backend
> system. There are cases where the response from the backend system will be
> useful to determine the actual problem which caused failure HTTP status code.
>
> Hence enhancements should be made to the exception class in a way to retrieve
> the actual response of the backend service.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
