Hi Francesco, 1.) Do you mean temporary for the merge or in general? Temporarily yes but our assumption was that V3 is not compatible with V4 and thus should not be in the library. At least for the server side.
2.) Provider Classes should be in the server module. I did not have time to move them yet. Also the current implementation uses the lazy loading which is not necessary in the client case so these have to be moved as well. I could do that. Should I do it in your branch or in the master branch? 3.) The idea was to keep packages independent so there is a EdmException in the EDM package only. The exceptions package is for common exceptions like a ODataRuntimeException or an ODataApplicationException. These Exceptions could also be moved to the root folder. WDYT? 4.) I have to look into that :) I will let you know as soon as I can say something useful. Best Regards, Christian -----Original Message----- From: Francesco Chicchiriccò [mailto:[email protected]] Sent: Dienstag, 18. Februar 2014 14:35 To: [email protected] Subject: [DISCUSS] Working on OLINGO-169 Hi all, I have just begun to take a look at odata4-commons-api and I have some questions. 1. The module contains a whole set of Edm interfaces matching the V4 CSDL specification (in the org.apache.olingo.odata4.commons.api.edm package). That's fine, but for V4 only: in order to merge ODataJClient, I need to identify some common interfaces and some specialized for v3 and v4: the resulting structure would then be org.apache.olingo.odata4.commons.api.edm - common stuff org.apache.olingo.odata4.commons.api.edm.v3 - OData 3.0 specific org.apache.olingo.odata4.commons.api.edm.v4 - OData 4.0 specific I would of course change current server-side implementation accordingly. Do you see any problem with that? 2. What are the classes under org.apache.olingo.odata4.commons.api.edm.provider meant for? They don't implement interfaces referenced above. Since I don't think we will need such classes for the ODataJClient merge, I would move them to package to odata4-server-api: WDYT? 3. Exception classes are either in a separate package (org.apache.olingo.odata4.commons.api.exception) but also elsewhere; is this wanted? 4. Is EdmTargetPath really needed? Is Atom feed customization (the feature this class I think was made for) supported at all in OData 4.0? Thanks! Regards. -- Francesco Chicchiriccò Tirasa - Open Source Excellence http://www.tirasa.net/ Involved at The Apache Software Foundation: member, Syncope PMC chair, Cocoon PMC, Olingo PPMC http://people.apache.org/~ilgrosso/
