[
https://issues.apache.org/jira/browse/AMBER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557198#comment-13557198
]
Stein Welberg edited comment on AMBER-64 at 1/18/13 1:10 PM:
-------------------------------------------------------------
Antonio. I have thought about it a little more and I don't like the solution
where we simply change the signature of the OAuthParametersApplier since the
other parameter appliers (BodyURLEncodedParametersApplier,
JSONBodyParametersApplier, WWWAuthHeaderParametersApplier) have nothing to do
with fragment params and their signature would also be changed. (or we could
add an extra method that also includes the fragment params but I would have to
change all the other parameter appliers as well and implement the method there
and throw a NotImplemented exception or whatever since that method is not
supported for those appliers.)
A far cleaner solution would be to add a FragmentParametersApplier that handles
the fragment parameters and make the distinction in the OAuthResponse class
(which is the only class that uses the QueryParametersApplier and wants to send
parameters in the url fragment.)
My solution is provided as a patch. (AMBER-64-separated query and
fragment.patch)
was (Author: steinwelberg):
Antonio. I have thought about it a little more and I don't like the
solution where we simply change the signature of the OAuthParametersApplier
since the other parameter appliers (BodyURLEncodedParametersApplier,
JSONBodyParametersApplier, WWWAuthHeaderParametersApplier) have nothing to do
with fragment params and their signature would also be changed. (or we could
add an extra method that also includes the fragment params but I would have to
change all the other parameter appliers as well and implement the method there
and throw a NotImplemented exception or whatever since that method is not
supported for those appliers.)
A far cleaner solution would be to add a FragmentParametersApplier that handles
the fragment parameters and make the distinction in the OAuthResponse class
(which is the only class that uses the QueryParametersApplier and wants to send
parameters in the url fragment.)
My solution is provided as a patch.
> QueryParameterApplier needs to include the scope parameter in the fragment
> ---------------------------------------------------------------------------
>
> Key: AMBER-64
> URL: https://issues.apache.org/jira/browse/AMBER-64
> Project: Amber
> Issue Type: Bug
> Reporter: Stein Welberg
> Assignee: Antonio Sanso
> Fix For: 0.23
>
> Attachments: AMBER-64_improved.patch, AMBER-64-separated query and
> fragment.patch
>
>
> According to the spec (see [0]) the scope parameter also needs to be included
> in the url fragment if it is provided.
> Please find the patch attached to fix this attached to this issue.
> [0] http://tools.ietf.org/html/rfc6749#section-4.2.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
