[
https://issues.apache.org/jira/browse/OLTU-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659475#comment-13659475
]
Simone Tripodi commented on OLTU-78:
------------------------------------
Thanks a lot Suresh for your patch, very appreciated.
Some observations that prevent me to apply it as is:
* please don't use the automatic IDE formatter - it adjusted license header
and class/methods comments
* the purpose of dropping the Map for private claims was to drop the key/value
resolution; the approach is anyway nice to support public claims;
* entities validation should be performed in the Entity.Builder#build()
method, not in the entity ctor;
* why did you drop the {{toString()}} methods?
good catch on duplicate keys in the JSON document! :)
> Implement Plaintext JWT
> ------------------------
>
> Key: OLTU-78
> URL: https://issues.apache.org/jira/browse/OLTU-78
> Project: Apache Oltu
> Issue Type: Sub-task
> Components: jwt
> Reporter: Suresh Attanayake
> Assignee: Antonio Sanso
> Attachments: AMBER-80.patch, OLTU-78.patch,
> support-for-public_and_private_claims-OLTU-78.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
