Github user francisco-perez-sorrosal commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/3#discussion_r73978116
--- Diff:
tso-server/src/test/java/org/apache/omid/tso/TestPersistenceProcessor.java ---
@@ -145,7 +145,7 @@ public void
testCommitPersistenceWithSingleCommitTableWriter() throws Exception
ObjectPool<Batch> batchPool = spy(new
BatchPoolModule(tsoConfig).getBatchPool());
- ReplyProcessor replyProcessor = new ReplyProcessorImpl(metrics,
panicker, batchPool);
+ ReplyProcessor replyProcessor = new ReplyProcessorImpl(tsoConfig,
metrics, panicker, batchPool);
--- End diff --
According to the changes above regarding to WaitStrategy injections, the
*ProcessorImpl clases in all the tests should create the objects of the
previous WaitStrategy in each case. This is the matching:
PersistenceProcessorImpl - BlockingWaitStrategy
ReplyProcessorImpl - BlockingWaitStrategy
RetryProcessorImpl - YieldingWaitStrategy
e.g. here should be:
```java
ReplyProcessor replyProcessor = new ReplyProcessorImpl(new
BlockingWaitStrategy(), metrics, panicker, batchPool);
```
The same applies to the other *ProcessorImpl instantiations below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
