Github user ohadshacham commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/13#discussion_r130805885
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/TTable.java ---
@@ -228,21 +261,12 @@ public void delete(Transaction tx, Delete delete)
throws IOException {
}
}
}
- if (issueGet) {
- // It's better to perform a transactional get to avoid
deleting more
- // than necessary
- Result result = this.get(transaction, deleteG);
- if (!result.isEmpty()) {
- for (Entry<byte[], NavigableMap<byte[], NavigableMap<Long,
byte[]>>> entryF : result.getMap()
- .entrySet()) {
- byte[] family = entryF.getKey();
- for (Entry<byte[], NavigableMap<Long, byte[]>> entryQ
: entryF.getValue().entrySet()) {
- byte[] qualifier = entryQ.getKey();
- deleteP.add(family, qualifier,
CellUtils.DELETE_TOMBSTONE);
- transaction.addWriteSetElement(new
HBaseCellId(table, delete.getRow(), family, qualifier,
-
transaction.getStartTimestamp()));
- }
- }
+
+ if (deleteFamily) {
--- End diff --
1. This is a deletion path without read requirement. It is doable only in
row level conflict detection mode where we only need to mark the row as a
player for conflict analysis.
2. TTable works only for HBase. You can see that each one of the method
starts with a check that the transaction is hbase transaction. IMHO TTable
should inherit from HTableInterface and override its functions, but this is for
a different patch :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
