[ https://issues.apache.org/jira/browse/OMID-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268396#comment-16268396 ]
ASF GitHub Bot commented on OMID-78: ------------------------------------ Github user yonigottesman commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/16#discussion_r153424921 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilter.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.omid.transaction; + +import java.io.IOException; +import java.util.List; +import java.util.Map; + +import org.apache.hadoop.hbase.Cell; +import org.apache.hadoop.hbase.client.Get; +import org.apache.hadoop.hbase.client.Result; +import org.apache.hadoop.hbase.client.ResultScanner; +import org.apache.hadoop.hbase.client.Scan; +import org.apache.omid.committable.CommitTable.CommitTimestamp; + +import com.google.common.base.Optional; + +public interface SnapshotFilter { + + public Result get(TTable ttable, Get get, HBaseTransaction transaction) throws IOException; + + public ResultScanner getScanner(TTable ttable, Scan scan, HBaseTransaction transaction) throws IOException; + + public List<Cell> filterCellsForSnapshot(List<Cell> rawCells, HBaseTransaction transaction, + int versionsToRequest, Map<String, List<Cell>> familyDeletionCache) throws IOException; + + public boolean isCommitted(HBaseCellId hBaseCellId, long epoch) throws TransactionException; --- End diff -- Why do all other function throw ioexceptions and this one something else? > Identify transaction snapshot at the server > ------------------------------------------- > > Key: OMID-78 > URL: https://issues.apache.org/jira/browse/OMID-78 > Project: Apache Omid > Issue Type: New Feature > Reporter: Ohad Shacham > Assignee: Ohad Shacham > > To identify a transaction's snapshot in scans and gets, Omid reads and filter > cells at the client side. This filtering requires checking the shadow cells > and accessing the commit table if needed. > Doing the filtering at the server side should be more efficient since less > data is being transferred to the client and also, in some cases, RPCs are > being saved. > This feature requires implementing a coprocessor that will do the filtering > at the server side and returns only the relevant snapshot to the client side. > This feature is also needed to support the integration of Omid with Phoenix. > This is required since Phoenix has coprocessors that change and condence the > data returned to the client and therefore, filtering at the client side in > this case is impossible. -- This message was sent by Atlassian JIRA (v6.4.14#64029)