[
https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561027#comment-16561027
]
ASF GitHub Bot commented on OMID-105:
-------------------------------------
Github user yonigottesman commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/39#discussion_r205961640
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java
---
@@ -98,20 +98,13 @@ void setCommitTableClient(CommitTable.Client
commitTableClient) {
* @param commitCache Holds shadow cells information
* @return Whether the cell was deleted
*/
- private boolean checkFamilyDeletionCache(Cell cell, HBaseTransaction
transaction, Map<String, List<Cell>> familyDeletionCache, Map<Long, Long>
commitCache) throws IOException {
- List<Cell> familyDeletionCells =
familyDeletionCache.get(Bytes.toString((cell.getRow())));
- if (familyDeletionCells != null) {
- for(Cell familyDeletionCell : familyDeletionCells) {
- String family = Bytes.toString(cell.getFamily());
- String familyDeletion =
Bytes.toString(familyDeletionCell.getFamily());
- if (family.equals(familyDeletion)) {
- Optional<Long> familyDeletionCommitTimestamp =
getCommitTimestamp(familyDeletionCell, transaction, commitCache);
- if (familyDeletionCommitTimestamp.isPresent() &&
familyDeletionCommitTimestamp.get() >= cell.getTimestamp()) {
- return true;
- }
- }
- }
+ private boolean checkFamilyDeletionCache(Cell cell, HBaseTransaction
transaction, Map<String, Long> familyDeletionCache, Map<Long, Long>
commitCache) throws IOException {
+ String key = Bytes.toString((cell.getRow())) + ":" +
Bytes.toString(cell.getFamily());
--- End diff --
export this + ":" + to a function
getRowFamilyString(Cell) and also use it later.
> Family deletion seek should continue when a tentative value is found
> ---------------------------------------------------------------------
>
> Key: OMID-105
> URL: https://issues.apache.org/jira/browse/OMID-105
> Project: Apache Omid
> Issue Type: Sub-task
> Reporter: Ohad Shacham
> Assignee: Ohad Shacham
> Priority: Major
>
>
> When a tentative family deletion marker is found. We need to continue looking
> until we either find a committed one in the past or no committed family
> deletion marker for this column is found. Otherwise, we might miss committed
> family deletion markers that exists in a transaction snapshot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
