Github user ohadshacham commented on a diff in the pull request:

    https://github.com/apache/incubator-omid/pull/41#discussion_r206843754
  
    --- Diff: 
hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java ---
    @@ -382,13 +385,16 @@ public int hashCode() {
                 hasher.putBytes(cell.getRowArray(), cell.getRowOffset(), 
cell.getRowLength());
                 hasher.putBytes(cell.getFamilyArray(), cell.getFamilyOffset(), 
cell.getFamilyLength());
                 int qualifierLength = cell.getQualifierLength();
    +            int qualifierOffset = cell.getQualifierOffset();
                 if (isShadowCell()) { // Update qualifier length when 
qualifier is shadow cell
                     qualifierLength = 
qualifierLengthFromShadowCellQualifier(cell.getQualifierArray(),
                             cell.getQualifierOffset(),
                             cell.getQualifierLength());
    +                qualifierOffset = qualifierOffset + 1;
    --- End diff --
    
    Will it work when the shadow cell prefix is absent? legacy data.


---

Reply via email to