Github user ohadshacham commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/46#discussion_r223993765
--- Diff:
tso-server/src/main/java/org/apache/omid/tso/RequestProcessorSkipCT.java ---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.omid.tso;
+
+import com.google.inject.Inject;
+import org.apache.omid.metrics.MetricsRegistry;
+import org.jboss.netty.channel.Channel;
+
+import java.io.IOException;
+
+public class RequestProcessorSkipCT extends AbstractRequestProcessor {
+
+
+ private final ReplyProcessor replyProcessor;
+
+ private final LeaseManagement leaseManager;
+ private final Panicker panicker;
+ private final String tsoHostAndPort;
+
+ @Inject
+ RequestProcessorSkipCT(MetricsRegistry metrics,
+ TimestampOracle timestampOracle,
+ ReplyProcessor replyProcessor,
+ Panicker panicker,
+ LeaseManagement leaseManager,
+ TSOServerConfig config,
+ LowWatermarkWriter lowWatermarkWriter,
+ String tsoHostAndPort) throws IOException {
+ super(metrics, timestampOracle, panicker, config,
lowWatermarkWriter);
+ this.replyProcessor = replyProcessor;
+ this.tsoHostAndPort = tsoHostAndPort;
+ requestRing = disruptor.start();
+ this.leaseManager = leaseManager;
+ this.panicker = panicker;
+ }
+
+ private void commitSuicideIfNotMaster() {
+ if (!leaseManager.stillInLeasePeriod()) {
+ panicker.panic("Replica " + tsoHostAndPort + " lost mastership
whilst flushing data. Committing suicide");
+ }
+ }
+
+ @Override
+ public void forwardCommit(long startTimestamp, long commitTimestamp,
Channel c, MonitoringContext monCtx) {
+ commitSuicideIfNotMaster();
--- End diff --
Add a comment that his is required since returning commit results when the
TSO is not the leader might violate snapshot isolation. This is because we have
to guarantee that committing transaction from previous tso has to persist all
its data because a new transaction started by a new tso.
---
