Agreed. Let's comment it out in <modules> list in autobind-parent, just to have Jenkins working properly, then will be fixed later.
Thanks Christian for putting effort on that! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Thu, Nov 29, 2012 at 11:50 AM, Daniel Manzke <[email protected]> wrote: > Mistake: I would exclude autobind-configuration ;) > > > 2012/11/29 Christian Grobmeier <[email protected]> > >> On Thu, Nov 29, 2012 at 11:35 AM, Daniel Manzke >> <[email protected]> wrote: >> > This is something Simo has to answer. ;) >> > >> > The IP is no problem I think due to the fact that this project was >> created >> > and owned by Simo. He has transfered it from google to github (into >> > nnsoft). >> >> Shouldn't configuration reader then be in our repository as well? >> googlecode -> github -> asf svn? >> >> >> > From my point of view the whole configuration module has to be redesigned >> > or separated/moved into Onami-Configuration. >> > Can we exclude it from build? >> >> Yes, we can (somehow). Lets wait what Simo explains and decide then. >> >> If we exlude Onami-Configuration we need to exclude Onami-Autobind too >> >> Cheers >> >> >> > >> > >> > 2012/11/29 Christian Grobmeier <[email protected]> >> > >> >> On Thu, Nov 29, 2012 at 11:26 AM, Daniel Manzke >> >> <[email protected]> wrote: >> >> > http://mavenhub.com/mvn/central/com.googlecode.rocoto/rocoto/4.0 >> >> > >> >> > com.googlecode.rocoto.configuration.ConfigurationReader >> >> > >> >> > That's why I wrote the upgrade to 5.0 was not done yet. ;) >> >> >> >> Sorry to ask, but what is that googlecode repository? >> >> Looking in the Rocoto we have from 99soft there is no >> ConfigurationReader. >> >> >> >> What does this mean for Onami - does this class come from googlecode >> >> (please let us mind the IP) >> >> or do we remove the COnfigurationReader interface from Autobind? >> >> >> >> While IP in mind, I would love to see the project passing through >> Jenkins >> >> >> >> Cheers + thanks for your patience >> >> Christian >> >> >> >> > >> >> > >> >> > 2012/11/29 Christian Grobmeier <[email protected]> >> >> > >> >> >> Ah btw, do you know what the ConfigurationReader in the autobind >> class >> >> >> org.nnsoft.guice.autobind.configuration.PropertiesReader >> >> >> is? I failed to find this class >> >> >> >> >> >> On Thu, Nov 29, 2012 at 11:14 AM, Christian Grobmeier >> >> >> <[email protected]> wrote: >> >> >> > OK, thanks Daniel. >> >> >> > I already changed a bit and will commit it now. >> >> >> > >> >> >> > On Thu, Nov 29, 2012 at 11:08 AM, Daniel Manzke >> >> >> > <[email protected]> wrote: >> >> >> >> +1. Autobind was submitted from my side to nnsoft. The >> configuration >> >> >> module >> >> >> >> was not fully updated to the latest rocoto (onami-configuration) >> >> >> version. >> >> >> >> This is still an open point. >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> 2012/11/29 Christian Grobmeier <[email protected]> >> >> >> >> >> >> >> >>> Hi, >> >> >> >>> >> >> >> >>> not sure how it worked before, but it seems >> >> >> >>> >> >> >> >>> Autobind: >> >> >> >>> org.nnsoft.guice.autobind.configuration.PropertiesReader >> >> >> >>> >> >> >> >>> makes use of: >> >> >> >>> >> >> >> >>> org.apache.onami.configuration.configuration.PropertiesURLReader >> >> >> >>> >> >> >> >>> Now PropertiesURLReader is package scoped. Even when I correct >> the >> >> >> >>> namespace for autobind it will fail. The solution is to make >> >> >> >>> PropertiesReader public. But I guess there was some reason to >> make >> >> it >> >> >> >>> package scoped in the past. >> >> >> >>> >> >> >> >>> Any objections if I would make this class public? >> >> >> >>> >> >> >> >>> Cheers >> >> >> >>> Christian >> >> >> >>> >> >> >> >>> -- >> >> >> >>> http://www.grobmeier.de >> >> >> >>> https://www.timeandbill.de >> >> >> >>> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> >> >> Viele Grüße/Best Regards >> >> >> >> >> >> >> >> Daniel Manzke >> >> >> > >> >> >> > >> >> >> > >> >> >> > -- >> >> >> > http://www.grobmeier.de >> >> >> > https://www.timeandbill.de >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> >> http://www.grobmeier.de >> >> >> https://www.timeandbill.de >> >> >> >> >> > >> >> > >> >> > >> >> > -- >> >> > Viele Grüße/Best Regards >> >> > >> >> > Daniel Manzke >> >> >> >> >> >> >> >> -- >> >> http://www.grobmeier.de >> >> https://www.timeandbill.de >> >> >> > >> > >> > >> > -- >> > Viele Grüße/Best Regards >> > >> > Daniel Manzke >> >> >> >> -- >> http://www.grobmeier.de >> https://www.timeandbill.de >> > > > > -- > Viele Grüße/Best Regards > > Daniel Manzke
