[
https://issues.apache.org/jira/browse/ONAMI-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533447#comment-13533447
]
Simone Tripodi commented on ONAMI-28:
-------------------------------------
Thanks for contributing, Mikhail!
{{com.google.inject.internal.util.$Preconditions.checkArgument()}} is the
equivalent of
[com.google.common.base.checkArgument()|http://code.google.com/p/guava-libraries/source/browse/guava/src/com/google/common/base/Preconditions.java#115]
that throws
[IllegalArgumentException|http://code.google.com/p/guava-libraries/wiki/PreconditionsExplained]
and, in order to keep backward compatibility, in your patch it would be better
if {{NPE}} is replaced by {{IAE}}.
Can you provide a new patch, please? TIA!
> Do not use code from com.google.inject.internal
> -----------------------------------------------
>
> Key: ONAMI-28
> URL: https://issues.apache.org/jira/browse/ONAMI-28
> Project: Apache Onami
> Issue Type: Bug
> Components: lifecycle
> Affects Versions: lifecycle-0.2
> Reporter: Mikhail Mazursky
> Priority: Blocker
> Attachments: ONAMI-28.patch
>
>
> 1. Those classes are internals and are subject to change (not a public
> API/SPI);
> 2. Guice do not export those packages in manifest so it will not resolve
> under OSGi.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
