Hi Simo,
With -P release, I've get a maven-gpg-plugin:1.4:sign (my current env is
not setup to sign).
Anyway, I think the src-jar (and test-src-jar) should be packaged with
the default profile.
I can commit in parent the needed definitions for this. Tell me if this
is ok for you.
From the jar content you show after, yes open the converter sandbox
please :)
Btw, are the conditions to go from sandbox to trunk already defined?
Thx, Eric
On 06/02/2013 15:28, Simone Tripodi wrote:
Hi again Eric,
I couldn't resist and gave a try, see r1443012; if you can update your
local copy of the repo, and repackaging the module turning the
'release' profile 'on', i.e.
mvn clean package -P release
The 'all' package is now generated in the correct way, it doesn't
contain maven meta-inf about the single module:
$ jar -tvf
all/target/org.apache.onami.converters.all-1.0.0-incubating-SNAPSHOT.jar
0 Wed Feb 06 16:16:46 CET 2013 META-INF/
1936 Wed Feb 06 16:16:44 CET 2013 META-INF/MANIFEST.MF
0 Wed Feb 06 16:16:44 CET 2013 META-INF/services/
0 Wed Feb 06 16:16:44 CET 2013 org/
0 Wed Feb 06 16:16:44 CET 2013 org/apache/
0 Wed Feb 06 16:16:44 CET 2013 org/apache/onami/
0 Wed Feb 06 16:16:46 CET 2013 org/apache/onami/converters/
0 Wed Feb 06 16:16:44 CET 2013 org/apache/onami/converters/core/
0 Wed Feb 06 16:16:46 CET 2013 org/apache/onami/converters/net/
0 Wed Feb 06 16:16:46 CET 2013 org/apache/onami/converters/numbers/
0 Wed Feb 06 16:16:46 CET 2013 org/apache/onami/converters/sql/
279 Wed Feb 06 16:16:44 CET 2013 META-INF/DEPENDENCIES
531 Wed Feb 06 16:16:44 CET 2013 META-INF/DISCLAIMER
11357 Wed Feb 06 16:16:44 CET 2013 META-INF/LICENSE
172 Wed Feb 06 16:16:44 CET 2013 META-INF/NOTICE
453 Wed Feb 06 16:16:44 CET 2013 META-INF/services/com.google.inject.Module
1229 Wed Feb 06 16:16:44 CET 2013
org/apache/onami/converters/core/AbstractConverter.class
1402 Wed Feb 06 16:16:46 CET 2013
org/apache/onami/converters/net/InetAddressConverter.class
1321 Wed Feb 06 16:16:46 CET 2013
org/apache/onami/converters/net/URIConverter.class
2268 Wed Feb 06 16:16:46 CET 2013
org/apache/onami/converters/net/URLConverter.class
949 Wed Feb 06 16:16:46 CET 2013
org/apache/onami/converters/numbers/BigDecimalConverter.class
949 Wed Feb 06 16:16:46 CET 2013
org/apache/onami/converters/numbers/BigIntegerConverter.class
1379 Wed Feb 06 16:16:46 CET 2013
org/apache/onami/converters/sql/ClobConverter.class
1178 Wed Feb 06 16:16:44 CET 2013
org/apache/onami/converters/sql/SQLDateConverter.class
1176 Wed Feb 06 16:16:46 CET 2013
org/apache/onami/converters/sql/SQLTimeConverter.class
1232 Wed Feb 06 16:16:46 CET 2013
org/apache/onami/converters/sql/SQLTimestampConverter.class
0 Wed Feb 06 16:16:46 CET 2013 META-INF/maven/
0 Wed Feb 06 16:16:46 CET 2013 META-INF/maven/org.apache.onami.converters/
0 Wed Feb 06 16:16:46 CET 2013
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.all/
4171 Wed Feb 06 16:16:14 CET 2013
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.all/pom.xml
163 Wed Feb 06 16:16:46 CET 2013
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.all/pom.properties
META-INF/services/com.google.inject.Module file contains all converters modules:
org.apache.onami.converters.net.InetAddressConverter
org.apache.onami.converters.net.URIConverter
org.apache.onami.converters.net.URLConverter
org.apache.onami.converters.numbers.BigDecimalConverter
org.apache.onami.converters.numbers.BigIntegerConverter
org.apache.onami.converters.sql.ClobConverter
org.apache.onami.converters.sql.SQLDateConverter
org.apache.onami.converters.sql.SQLTimeConverter
org.apache.onami.converters.sql.SQLTimestampConverter
That should be enough ATM. Do you think we can 'officially' open the
sandbox - that's been rather an experiment - creating the JIRA
component and uploading the site?
TIA, all the best,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Wed, Feb 6, 2013 at 12:15 PM, Eric Charles <[email protected]> wrote:
I like it Simo!
org.apache.onami.converters.all-1.0.0-incubating-SNAPSHOT.jar has it all
(classes + META-INF files).
Ideally, LICENSE, NOTICE and DISCLAIMER should come at the root, and not
under META-INF to avoid questions from release voters.
Also, src-jar is not present, but that should be solved on the parent level
(other onami modules don't generate the src-jar either).
Thx, Eric
eric:tmp eric$ unzip
org.apache.onami.converters.all-1.0.0-incubating-SNAPSHOT.jar
Archive: org.apache.onami.converters.all-1.0.0-incubating-SNAPSHOT.jar
inflating: org/apache/onami/converters/sql/SQLTimestampConverter.class
inflating: org/apache/onami/converters/sql/SQLTimeConverter.class
inflating: org/apache/onami/converters/sql/SQLDateConverter.class
inflating: org/apache/onami/converters/sql/ClobConverter.class
inflating: org/apache/onami/converters/numbers/BigIntegerConverter.class
inflating: org/apache/onami/converters/numbers/BigDecimalConverter.class
inflating: org/apache/onami/converters/net/URLConverter.class
inflating: org/apache/onami/converters/net/URIConverter.class
inflating: org/apache/onami/converters/net/InetAddressConverter.class
inflating: org/apache/onami/converters/core/AbstractConverter.class
inflating: META-INF/services/com.google.inject.Module
inflating:
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.sql/pom.xml
inflating:
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.sql/pom.properties
inflating:
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.numbers/pom.xml
inflating:
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.numbers/pom.properties
inflating:
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.net/pom.xml
inflating:
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.net/pom.properties
inflating:
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.core/pom.xml
inflating:
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.core/pom.properties
inflating:
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.all/pom.xml
inflating:
META-INF/maven/org.apache.onami.converters/org.apache.onami.converters.all/pom.properties
inflating: META-INF/maven/com.google.guava/guava/pom.xml
inflating: META-INF/maven/com.google.guava/guava/pom.properties
inflating: META-INF/NOTICE
inflating: META-INF/MANIFEST.MF
inflating: META-INF/LICENSE
inflating: META-INF/DISCLAIMER
inflating: META-INF/DEPENDENCIES
eric:tmp eric$ more META-INF/services/com.google.inject.Module
org.apache.onami.converters.net.InetAddressConverter
org.apache.onami.converters.net.URIConverter
org.apache.onami.converters.net.URLConverter
eric:tmp eric$
On 05/02/2013 20:42, Simone Tripodi wrote:
Hi all,
I just found he time to check-in a PoC about my vision about the
converters[1] component; as I described before, I wanted to reach a
good level of granularization there, I started dividing the converters
by "areas".
So, we do have a 'core' module which contains shared stuff across all
converters, there is the 'net' module which contains converters
related to java.net objects, such URI, URL, ..., then we have the
'sql' module which takes care about all java.sql type conversion, ...,
and the 'all' module which packages all the previous one module in a
big fat artifact.
I didn't copied all converters from [configuration] but my purpose ATM
was just providing an implementation about the idea I gave on the past
week, so you can have a look at it.
WDYT?
Happy hacking!
-Simo
[1] https://svn.apache.org/repos/asf/incubator/onami/sandbox/converters
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
