----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3543/ -----------------------------------------------------------
(Updated 2012-01-19 02:54:44.310091) Review request for oodt. Summary ------- See OODT-341: https://issues.apache.org/jira/browse/OODT-341 * CDEResult extends org.apache.oodt.xmlquery.Result * CDEResult mimetype is always "text/plain" * CDEResult size is always 0 * CDEResult inputstream is CDEResultInputStream * CDEResultInputStream has IO methods and wraps a CDEResult * CDEResult wraps a ResultSet and returns rows as Strings, applying MappingFuncs if a Mapping is provided, and appending constant fields if a List of CDEValues is provided. * ProductQueryServlet relies on servlet container to handle Content-Length (and possibly Transfer-Encoding: chunked) This addresses bug OODT-341. https://issues.apache.org/jira/browse/OODT-341 Diffs ----- trunk/grid/src/main/java/org/apache/oodt/grid/ProductQueryServlet.java 1183564 trunk/xmlps/pom.xml 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/DBMSExecutor.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResultInputStream.java PRE-CREATION trunk/xmlps/src/test/java/org/apache/oodt/xmlps/structs/TestCDEResult.java PRE-CREATION trunk/xmlps/src/test/java/org/apache/oodt/xmlps/structs/TestCDEResultInputStream.java PRE-CREATION Diff: https://reviews.apache.org/r/3543/diff Testing (updated) ------- Runs in Tomcat 7. I've used it at CHLA. NOT tested in other app servers. Which other app servers should I test? NOT tested MappingFuncs. Is it necessary? Added 2 unit tests: TestCDEResult and TestCDEResultInputStream, which both pass. Thanks, Ricky
