> On 2012-03-15 00:35:26, brian Foster wrote: > > Why can't DataSourceCatalog be extended and just modified per hypersonic > > needs?... what are the differences exactly between DataSource and Hyersonic > > versions of the Catalogs?
Hey Brian, great question. The reality is that this catalog was hidden away in the File Manager test suite inside of TestDataSourceCatalog. There was something wiggy about the DataSourceCatalog code that Hypersonic SQL didn't like so I had to extend DataSourceCatalog for internal testing since it made sense to use Hypersonic SQL for that (could load up the DBMS in memory, etc.) I know that there was like 1 method that used incompatible SQL syntax that Hypersonic SQL didn't like. Then when I overrode that one method, I had to override like 4-5 others to inject my subclass method into the call chain for that which is what you see in the patch. It seems that DataSourceCatalog has since evolved and it's entirely possible that it would support Hypersonic SQL now, so here's what I see as 2 options: 1. we try and simply remove Hypersonic SQL catalog period, and then see if the TestDataSourceCatalog passes. If it does, this issue is moot and I will close this ReviewBoard and the issue. 2. If #1 doesn't succeed, and suggests changes, we could: a) flow those changes into DataSourceCatalog -- someone would have to have time to do that :) It also could happen later; or b) suggest that since this catalog exists and we know it works, temporarily in 0.4 and ongoing until someone refactors or improves DataSourceCatalog ship the HypersonicSQLFriendlyCatalog for folks who want to use it. Sound right? Thoughts? - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4358/#review5978 ----------------------------------------------------------- On 2012-03-14 23:40:55, Chris Mattmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4358/ > ----------------------------------------------------------- > > (Updated 2012-03-14 23:40:55) > > > Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas > Bennett. > > > Summary > ------- > > DataSourceCatalog compatible with HypersonicSQL > > > This addresses bug OODT-410. > https://issues.apache.org/jira/browse/OODT-410 > > > Diffs > ----- > > > ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/HsqlDbFriendlyDataSourceCatalog.java > PRE-CREATION > > ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/HsqlDbFriendlyDataSourceCatalogFactory.java > PRE-CREATION > > ./trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java > 1294690 > > Diff: https://reviews.apache.org/r/4358/diff > > > Testing > ------- > > > Thanks, > > Chris > >
