----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4374/#review6014 -----------------------------------------------------------
Ship it! LGTM. Nice catch Ricky -- what about a small unit test for regression? - Chris On 2012-03-16 01:51:02, Ricky Nguyen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4374/ > ----------------------------------------------------------- > > (Updated 2012-03-16 01:51:02) > > > Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and > Thomas Bennett. > > > Summary > ------- > > filemgr query throws NPE when some products have undefined metadata values > > > This addresses bug OODT-413. > https://issues.apache.org/jira/browse/OODT-413 > > > Diffs > ----- > > > trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LuceneCatalog.java > 1300633 > > Diff: https://reviews.apache.org/r/4374/diff > > > Testing > ------- > > tested at CHLA with command: > > ./filemgr-client -u $FILEMGR_URL -op -sql -of '$VpsEpisodeStartTime' -q > "SELECT VpsEpisodeStartTime FROM CernerEvents" > > > Thanks, > > Ricky > >