> On 2012-03-16 14:28:24, Chris Mattmann wrote: > > trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java, line > > 108 > > <https://reviews.apache.org/r/4375/diff/2/?file=93053#file93053line108> > > > > what makes this throw an exception now? > > brian Foster wrote: > I'm gradually adding "throws Exception" to all the methods in CAS-PGE's > PGETaskInstance so if they are overridden by the extending class, the > extending class can easily kill CAS-PGE (and give the reason why it should > stop) by just throwing any Exception
+1, makes sense to me. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4375/#review6035 ----------------------------------------------------------- On 2012-03-16 08:25:17, brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4375/ > ----------------------------------------------------------- > > (Updated 2012-03-16 08:25:17) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Summary > ------- > > This handler will allow for multiple CAS-PGE instances to exist in the same > JVM while routing the logging from each to their own log files in their > execution directory > > ----- > This patch also includes: > - adding support for PgeMetadata to take PgeTaskMetKeys directly > - some cleanup and reorganizing of PgeTaskInstance > > > This addresses bug OODT-414. > https://issues.apache.org/jira/browse/OODT-414 > > > Diffs > ----- > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java > 1301267 > trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogHandler.java > PRE-CREATION > trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogRecord.java > PRE-CREATION > trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java > 1300798 > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java > 1301267 > trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1301267 > trunk/pge/src/test/org/apache/oodt/cas/pge/logging/TestPgeLogHandler.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4375/diff > > > Testing > ------- > > Added and updated unit-tests > > > Thanks, > > brian > >
