filed subtask OODT-431 under OODT-410.
simple fix, didn't think i needed review board since all discussion happened
for OODT-410 already.
committed and seems like jenkins build succeeds.
On Mar 22, 2012, at 8:13 AM, Ramirez, Paul M (388J) wrote:
> Hey Chris,
>
> Yep, you're right so I'll look into this further. I know that commit broke
> the build as Jenkins keeps telling the list. I wonder if the bug was there
> before. If I recall you just expanded the unit test. Anyhow when I have more
> time I'll try to track this down if someone doesn't get to it first.
> Essentially, the unit test is failing right now.
>
> --Paul
>
> On Mar 21, 2012, at 1:18 PM, Mattmann, Chris A (388J) wrote:
>
>> Hi Paul,
>>
>> On Mar 21, 2012, at 3:41 PM, Ramirez, Paul M (388J) wrote:
>>
>>> Hey Guys,
>>>
>>> This commit broke the unit test
>>> (org.apache.oodt.cas.filemgr.catalog.TestMappedDataSourceCatalog) with the
>>> addition of:
>>>
>>> assertEquals("ShouldBeFirstForPage.txt",
>>> ((Product)myCat.getFirstPage(type).getPageProducts().get(0)).getProductName());
>>
>> Hmmm, that commit was from me. Read on below.
>>
>>>
>>> The data source catalog is sorted by product id so this test does not
>>> succeed (since 20 products were added before it) as it would with the
>>> lucene catalog which is naturally sorted by CAS.ProductReceivedTime. I can
>>> fix the test to look at the second page but wanted to make sure the intent
>>> was captured. Also this is sort of an oddity with our catalogs having one
>>> set sorted by default with product id and the other with time.
>>>
>>
>> Sorting in the DataSourceCatalog by product ID should be equivalent to
>> sorting in the Lucene Catalog by ProductReceivedTime, right?
>>
>> Cheers,
>> Chris
>>
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> Chris Mattmann, Ph.D.
>> Senior Computer Scientist
>> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
>> Office: 171-266B, Mailstop: 171-246
>> Email: chris.a.mattm...@nasa.gov
>> WWW: http://sunset.usc.edu/~mattmann/
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> Adjunct Assistant Professor, Computer Science Department
>> University of Southern California, Los Angeles, CA 90089 USA
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>
>
---------------------------------------------------------------------
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments,
is for the sole use of the intended recipient(s) and may contain confidential
or legally privileged information. Any unauthorized review, use, disclosure
or distribution is prohibited. If you are not the intended recipient, please
contact the sender by reply e-mail and destroy all copies of this original
message.
---------------------------------------------------------------------
