----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4454/#review6279 -----------------------------------------------------------
Ship it! I've tested it. Looks good to me! trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java <https://reviews.apache.org/r/4454/#comment13622> May need to test for boolean optionsInstances, i.e. where optionInstance.getValues().size() == 0. - Thomas On 2012-03-22 21:27:55, brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4454/ > ----------------------------------------------------------- > > (Updated 2012-03-22 21:27:55) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Summary > ------- > > It currently was setting lists keys to: value1,value2,value3,... > > This patch will instead change it to: > key[0] = value1 > key[1] = value2 > > > This addresses bug OODT-428. > https://issues.apache.org/jira/browse/OODT-428 > > > Diffs > ----- > > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java > 1304041 > > Diff: https://reviews.apache.org/r/4454/diff > > > Testing > ------- > > still need a unit-test for this... will write when i get the time > > > Thanks, > > brian > >
