----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4451/ -----------------------------------------------------------
(Updated 2012-03-22 23:47:07.464893) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett. Changes ------- decided to write unit tests for QueryResult, instead of adding a test to TestSqlQueryCliAction Summary ------- Cleaned up metadata to string methods of QueryResult. If metadata was empty, it was trying to delete a trailing comma that doesn't exist. This addresses bug OODT-427. https://issues.apache.org/jira/browse/OODT-427 Diffs (updated) ----- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java 1303205 trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java 1303205 trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java PRE-CREATION Diff: https://reviews.apache.org/r/4451/diff Testing ------- Added unit test to check for empty metadata. Changed existing unit test to account for implementation-dependent ordering of keys. Thanks, Ricky