----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4458/#review6348 -----------------------------------------------------------
Ship it! LGTM. trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java <https://reviews.apache.org/r/4458/#comment13773> Agreed. - Chris On 2012-03-23 21:19:16, Ricky Nguyen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4458/ > ----------------------------------------------------------- > > (Updated 2012-03-23 21:19:16) > > > Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl > John, and Thomas Bennett. > > > Summary > ------- > > putting nulls last > > > This addresses bug OODT-429. > https://issues.apache.org/jira/browse/OODT-429 > > > Diffs > ----- > > > trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java > 1303205 > > trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4458/diff > > > Testing > ------- > > wrote unit test > > > Thanks, > > Ricky > >