----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4444/ -----------------------------------------------------------
(Updated 2012-03-27 00:47:30.189828) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Changes ------- - Updated unit-tests -- ProductCrawler has a unit-test for each possible path that can be taken through handleFile(File) and verifies the appropriate methods where called Summary ------- - Introduced NamingConvention support, which for MetExtractorProductCrawler now takes an ID for the NamingConvention to use and AutoDetectProductCrawler has a new element <namingConvention class=""/> in MimeExtractorRepo - Also cleaned up handleFile(File)... documented better and is now public and returns the IngestResult for what happened when called. This addresses bug OODT-426. https://issues.apache.org/jira/browse/OODT-426 Diffs (updated) ----- trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 1305657 trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorProductCrawler.java 1305657 trunk/crawler/pom.xml 1305657 trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/AutoDetectProductCrawler.java 1305657 trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java 1305657 trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MetExtractorSpec.java 1305657 trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigMetKeys.java 1305657 trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java 1305657 trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorRepo.java 1305657 trunk/crawler/src/main/resources/cmd-line-options.xml 1305657 trunk/crawler/src/main/resources/crawler-config.xml 1305657 trunk/crawler/src/main/resources/examples/mime-extractor-map.xml 1305657 trunk/crawler/src/main/resources/naming-beans.xml PRE-CREATION trunk/crawler/src/test/org/apache/oodt/cas/crawl/StateAwareProductCrawler.java PRE-CREATION trunk/crawler/src/test/org/apache/oodt/cas/crawl/TestProductCrawler.java PRE-CREATION trunk/crawler/src/test/org/apache/oodt/cas/crawl/typedetection/TestMimeExtractorConfigReader.java PRE-CREATION Diff: https://reviews.apache.org/r/4444/diff Testing (updated) ------- Wrote several unit-tests Thanks, brian