----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6357/#review9844 -----------------------------------------------------------
Ship it! LGTM! trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java <https://reviews.apache.org/r/6357/#comment20879> we should change this to 9001 - Chris Mattmann On Aug. 3, 2012, 10:47 p.m., brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6357/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2012, 10:47 p.m.) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Description > ------- > > Added EngineRunnerFactory interface and implementations > > > This addresses bug OODT-310. > https://issues.apache.org/jira/browse/OODT-310 > > > Diffs > ----- > > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/EngineRunner.java > 1369233 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/EngineRunnerFactory.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/PrioritizedQueueBasedWorkflowEngine.java > 1369233 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/ResourceRunnerFactory.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/ThreadPoolWorkflowEngine.java > 1369233 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/ThreadPoolWorkflowEngineFactory.java > 1369233 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowEngine.java > 1369233 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowEngineFactory.java > 1369233 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java > 1369233 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/util/GenericWorkflowObjectFactory.java > 1369233 > > Diff: https://reviews.apache.org/r/6357/diff/ > > > Testing > ------- > > > Thanks, > > brian Foster > >
