----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6407/#review9949 -----------------------------------------------------------
Ship it! LGTM! - Chris Mattmann On Aug. 6, 2012, 8:41 p.m., brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6407/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2012, 8:41 p.m.) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Description > ------- > > EngineRunner classes will be put into a new package in: > org.apache.oodt.cas.workflow.engine.runner > WorkflowProcessor classes will be out into a new package in: > org.apache.oodt.cas.workflow.engine.processor > This will also include two EngineRunnerFactories which where left out of > OODT-310 patch > > > This addresses bug OODT-485. > https://issues.apache.org/jira/browse/OODT-485 > > > Diffs > ----- > > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/AsynchronousLocalEngineRunner.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/ConditionProcessor.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/EngineRunner.java > 1369914 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/EngineRunnerFactory.java > 1369914 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/ParallelProcessor.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/PrioritizedQueueBasedWorkflowEngine.java > 1369914 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/ProcessorDateTimeInfo.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/ResourceRunner.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/ResourceRunnerFactory.java > 1369914 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/SequentialProcessor.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/SynchronousLocalEngineRunner.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskProcessor.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskRunner.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/ThreadPoolWorkflowEngine.java > 1369914 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowEngine.java > 1369914 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessorBuilder.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessorListener.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessorQueue.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/ConditionProcessor.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/ParallelProcessor.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/ProcessorDateTimeInfo.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/SequentialProcessor.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/TaskProcessor.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/WorkflowProcessor.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/WorkflowProcessorBuilder.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/WorkflowProcessorListener.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/WorkflowProcessorQueue.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/AsynchronousLocalEngineRunner.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/AsynchronousLocalEngineRunnerFactory.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/EngineRunner.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/EngineRunnerFactory.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/ResourceRunner.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/ResourceRunnerFactory.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/SynchronousLocalEngineRunner.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/SynchronousLocalEngineRunnerFactory.java > PRE-CREATION > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/FILOPrioritySorter.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/HighestFIFOPrioritySorter.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/HighestPrioritySorter.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/PrioritySorter.java > 1369913 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java > 1369914 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/util/GenericWorkflowObjectFactory.java > 1369914 > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/util/WorkflowUtils.java > 1369913 > > trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/MockProcessorQueue.java > 1369913 > > trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/QuerierAndRunnerUtils.java > 1369913 > > trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestAsynchronousLocalEngineRunner.java > 1369913 > > trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java > 1369913 > > trunk/workflow/src/test/org/apache/oodt/cas/workflow/structs/TestFILOPrioritySorter.java > 1369913 > > trunk/workflow/src/test/org/apache/oodt/cas/workflow/structs/TestHighestFIFOPrioritySorter.java > 1369913 > > trunk/workflow/src/test/org/apache/oodt/cas/workflow/structs/TestHighestPrioritySorter.java > 1369913 > > Diff: https://reviews.apache.org/r/6407/diff/ > > > Testing > ------- > > ran unit-tests > > > Thanks, > > brian Foster > >