> On April 17, 2013, 3:40 a.m., Chris Mattmann wrote: > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/BasePage.css, > > line 10 > > <https://reviews.apache.org/r/10535/diff/1/?file=281445#file281445line10> > > > > I recommend making this change in a BasePage_<skin name>.css, or > > perhaps BasePage_oodt.css.
Excellent suggestion Chris! I've taken your point about creating pluggable skins and filed a sub-task JIRA for this: https://issues.apache.org/jira/browse/OODT-599 > On April 17, 2013, 3:40 a.m., Chris Mattmann wrote: > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/DefaultSkin.css, > > line 5 > > <https://reviews.apache.org/r/10535/diff/1/?file=281448#file281448line5> > > > > again, DefaultSkin_oodt.css would be good here. Thanks! See: https://issues.apache.org/jira/browse/OODT-599. I'm planning to port the contents of DefaultSkin.css to BasePage_<skin>.css. Within the Wicket model, there really is no need for a separate skin file that is separate from BasePage_<skin>.css since the latter is always loaded into every page. I think it makes is confusing to have a third CSS file that is manually loaded into every page just like BasePage_<skin>.css is. Plus, this ensures that whenever someone needs to edit/make their skin, then they only need to modify two CSS files: HomePage_<skin>.css and BasePage_<skin>.css. > On April 17, 2013, 3:40 a.m., Chris Mattmann wrote: > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/HomePage.css, > > line 8 > > <https://reviews.apache.org/r/10535/diff/1/?file=281449#file281449line8> > > > > HomePage_oodt.css. +1, and thanks for this suggestion! See: https://issues.apache.org/jira/browse/OODT-599 > On April 17, 2013, 3:40 a.m., Chris Mattmann wrote: > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/HomePage.java, > > line 37 > > <https://reviews.apache.org/r/10535/diff/1/?file=281450#file281450line37> > > > > seems like this change could be its own review, which is basically > > getting rid of the page expired error. You may want to separate that out. > > Chris Mattmann wrote: > Reesh also the 2 logos should have _<skin name> in them too. Thanks! +1. All skin related images have the _<skin> suffix now. > On April 17, 2013, 3:40 a.m., Chris Mattmann wrote: > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/OPSUIWebPage.java, > > line 2 > > <https://reviews.apache.org/r/10535/diff/1/?file=281451#file281451line2> > > > > Needs Apache header. +1. > On April 17, 2013, 3:40 a.m., Chris Mattmann wrote: > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/BasePage.html, > > line 55 > > <https://reviews.apache.org/r/10535/diff/1/?file=281446#file281446line55> > > > > rather than change BasePage.html, how about making this change in a > > BasePage_oodt.html or more generally BasePage_<skin name>.html. +1. - Rishi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10535/#review19299 ----------------------------------------------------------- On April 17, 2013, 3:40 a.m., Rishi Verma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10535/ > ----------------------------------------------------------- > > (Updated April 17, 2013, 3:40 a.m.) > > > Review request for oodt, Chris Mattmann, Andrew Hart, Paul Ramirez, and > Cameron Goodale. > > > Description > ------- > > Hey all, > > Per JIRA Issue: https://issues.apache.org/jira/browse/OODT-597, I proposed we > update some of OPSUI's look and feel to make it more readable. > > The attached diff resolves all points addressed in OODT-597, so please take a > look at that for more details. I've attached some screenshots of what the new > OPSUI looks like - for your convenience. > > I know A LOT of work must have gone into the original OPSUI look and feel. So > I want to make sure my improvements to it (and in some cases changes) are > transparent and reviewed before we push. Like I said in OODT-597, the old > OPSUI was very slick. I feel it was a little bit to read though on > low-contrast screens, and that's why I proposed an improvement to the theme. > Also, I think its good if we keep some consistency between how we do OODT > logos, coloring, and themeing to make sure we are generating a consistent > product. > > Anyways, let me know what you think! I'll push the commits when I get a 'ship > it'! :D > > rishi > > > This addresses bug OODT-597. > https://issues.apache.org/jira/browse/OODT-597 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/BasePage.css > 1468173 > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/BasePage.html > 1468173 > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/BasePage.java > 1468173 > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/DefaultSkin.css > 1468173 > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/HomePage.css > 1468173 > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/HomePage.java > 1468173 > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/OPSUIWebPage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/project_logo.png > UNKNOWN > > http://svn.apache.org/repos/asf/oodt/trunk/pcs/opsui/src/main/java/org/apache/oodt/pcs/opsui/splash.png > UNKNOWN > > Diff: https://reviews.apache.org/r/10535/diff/ > > > Testing > ------- > > Local testing. See screenshots. > > > Screenshots > ----------- > > Splash page > https://reviews.apache.org/r/10535/s/20/ > Workflow monitor page > https://reviews.apache.org/r/10535/s/21/ > Workflow tasks diagram > https://reviews.apache.org/r/10535/s/22/ > Workflow task info > https://reviews.apache.org/r/10535/s/23/ > File Manager browser page > https://reviews.apache.org/r/10535/s/24/ > > > Thanks, > > Rishi Verma > >
