Hey Luca,

I pretty much reached the same conclusion - so I agree with your proposed
change.

Please go ahead and update.

Cheers,
Tom



On 28 May 2013 16:51, Cinquini, Luca (3980) <luca.cinqu...@jpl.nasa.gov>wrote:

> Hi Thomas,
>         thanks for trying this out... I actually plan to use the Solr
> back-end in a real life scenario real soon, so between the two of us we
> should hammer out all possible issues.
>
> Coming to your question... It seems to me like the best course of action
> would be for SolrCatalog to return "null" if numFound=0, instead of
> throwing an exception... This would be compatible with the invocation from
> the XmlRpcFileManager:
>
>     public boolean hasProduct(String productName) throws CatalogException {
>         Product p = catalog.getProductByName(productName);
>         return p != null
>                 && p.getTransferStatus().equals(Product.STATUS_RECEIVED);
>     }
>
> If you agree, I will make the change. This should solve your problem....
>
> thanks, Luca
>
> On May 24, 2013, at 2:31 AM, Thomas Bennett wrote:
>
> > Hey Luca,
> >
> > I'm getting my Solr catalog up and running. I've got one interesting
> > problem at the moment. I set --actionIds Unique on my cataloger.
> >
> > Cataloger calls hasProduct on the XMLRPC interface.
> > Filemanager eventually calls the following method: extractCompleteProduct
> >
> > private CompleteProduct extractCompleteProduct(String doc)
> > throwsCatalogException {
> >
> > Now if numFound==0 it raises an exception
> >
> > } else if (numFound==0) {throw new CatalogException("No products found in
> > response document");
> >
> > This is a problem if you're wanting to actually check to see if the file
> is
> > in the catalog :)
> >
> > The exception raised is the general CatalogException. Perhaps a
> specialised
> > exception should be raised so that it could be caught and handled
> > appropriately... Since its your code I thought I would rather ask what
> you
> > think.
> >
> > Otherwise +1. I've got my Solr catalog up and running on my dev machine.
> If
> > it all checks out - I plan to roll it out to site in the next month or
> so.
> >
> > Cheers,
> >
> > Tom
> >
> >
> > On 30 April 2013 01:35, Cinquini, Luca (3980) <
> luca.cinqu...@jpl.nasa.gov>wrote:
> >
> >> Hi Thomas,
> >>        please, and let me know... You probably know where the
> >> documentation is, but just in case:
> >>
> >>
> >>
> https://cwiki.apache.org/confluence/display/OODT/Solr+File+Manager+Quick+Start+Guide
> >>
> >>
> >>
> https://cwiki.apache.org/confluence/display/OODT/Solr+File+Manager+Developer%27s+Guide
> >>
> >> thanks, Luca
> >>
> >> On Apr 29, 2013, at 1:10 AM, Thomas Bennett wrote:
> >>
> >>> Hey Luca,
> >>>
> >>> Thanks for this. I'm going to give it a whirl too. Great work!
> >>>
> >>> Cheers,
> >>> Tom
> >>>
> >>>
> >>> On 27 April 2013 17:56, Cinquini, Luca (3980) <
> >> luca.cinqu...@jpl.nasa.gov>wrote:
> >>>
> >>>> Thanks Rishi, there's two guides on the apache wiki by the way.
> >>>> Let me know if you find any problems,
> >>>> Luca
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> On Apr 27, 2013, at 9:50 AM, "Verma, Rishi (398J)" <
> >>>> rishi.ve...@jpl.nasa.gov> wrote:
> >>>>
> >>>>> NICE Luca! This is excellent!
> >>>>>
> >>>>> Looking forward to trying this out.
> >>>>>
> >>>>> rishi
> >>>>>
> >>>>> On Apr 26, 2013, at 12:02 PM, Luca Cinquini (JIRA) wrote:
> >>>>>
> >>>>>>
> >>>>>>  [
> >>>>
> >>
> https://issues.apache.org/jira/browse/OODT-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> >> ]
> >>>>>>
> >>>>>> Luca Cinquini resolved OODT-592.
> >>>>>> --------------------------------
> >>>>>>
> >>>>>> Resolution: Fixed
> >>>>>>
> >>>>>> First implementation of native Solr FM back-end has been inserted
> into
> >>>> trunk.
> >>>>>>
> >>>>>> See review board:
> >>>>>>
> >>>>>> https://reviews.apache.org/r/10288/
> >>>>>>
> >>>>>> and documentation:
> >>>>>>
> >>>>>>
> >>>>
> >>
> https://cwiki.apache.org/confluence/display/OODT/Solr+File+Manager+Quick+Start+Guide
> >>>>>>
> >>>>>>
> >>>>
> >>
> https://cwiki.apache.org/confluence/display/OODT/Solr+File+Manager+Developer%27s+Guide
> >>>>>>
> >>>>>>> Native Solr implementation of CAS File manager
> >>>>>>> ----------------------------------------------
> >>>>>>>
> >>>>>>>             Key: OODT-592
> >>>>>>>             URL: https://issues.apache.org/jira/browse/OODT-592
> >>>>>>>         Project: OODT
> >>>>>>>      Issue Type: New Feature
> >>>>>>>      Components: file manager
> >>>>>>> Affects Versions: 0.5
> >>>>>>>        Reporter: Luca Cinquini
> >>>>>>>        Assignee: Luca Cinquini
> >>>>>>>         Fix For: 0.6
> >>>>>>>
> >>>>>>>
> >>>>>>> Implement the CAS Catalog interface versus a standalone Solr
> server,
> >>>> so that after products are ingested, their metadata can be query
> >>>> efficiently by clients.
> >>>>>>> See review board: https://reviews.apache.org/r/10288/
> >>>>>>
> >>>>>> --
> >>>>>> This message is automatically generated by JIRA.
> >>>>>> If you think it was sent incorrectly, please contact your JIRA
> >>>> administrators
> >>>>>> For more information on JIRA, see:
> >>>> http://www.atlassian.com/software/jira
> >>>>>
> >>>>
> >>
> >>
>
>

Reply via email to