----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18944/#review45711 -----------------------------------------------------------
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitor.java <https://reviews.apache.org/r/18944/#comment80672> Why do we need this class? I don't get it. trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java <https://reviews.apache.org/r/18944/#comment80673> don't get this change? trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java <https://reviews.apache.org/r/18944/#comment80674> what's up with this change? trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java <https://reviews.apache.org/r/18944/#comment80675> Ditto trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java <https://reviews.apache.org/r/18944/#comment80676> why all these spacing changes? trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java <https://reviews.apache.org/r/18944/#comment80677> spacing change trunk/resource/src/main/resources/resource.properties <https://reviews.apache.org/r/18944/#comment80678> shouldn't be disabled - we just need the code that was there before for AssignmentMonitor. Then we should have a GangliaAssignmentMonitor that you can enable - but we don't need a disabled version? - Chris Mattmann On March 9, 2014, 4:44 a.m., Rajith Siriwardana wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18944/ > ----------------------------------------------------------- > > (Updated March 9, 2014, 4:44 a.m.) > > > Review request for oodt and Chris Mattmann. > > > Bugs: OODT-669 > https://issues.apache.org/jira/browse/OODT-669 > > > Repository: oodt > > > Description > ------- > > Patch contains disabling Resource Monitor feature in Assignment Monitor and > also some re-factored code for assignment monitor > > > Diffs > ----- > > > trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/AssignmentMonitor.java > 1575649 > > trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitor.java > PRE-CREATION > > trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitorFactory.java > PRE-CREATION > > trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java > 1575649 > > trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java > 1575649 > trunk/resource/src/main/resources/resource.properties 1575649 > > trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestAssignmentMonWithNoResourceMon.java > PRE-CREATION > trunk/resource/src/testdata/test.disabledmon.resource.properties > PRE-CREATION > > Diff: https://reviews.apache.org/r/18944/diff/ > > > Testing > ------- > > Disabled monitor with Assignment monitor was tested > > > Thanks, > > Rajith Siriwardana > >
