----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22671/ -----------------------------------------------------------
(Updated June 17, 2014, 3:18 a.m.)
Review request for oodt and Chris Mattmann.
Bugs: oodt-685, oodt-688 and oodt-691
https://issues.apache.org/jira/browse/oodt-685
https://issues.apache.org/jira/browse/oodt-688
https://issues.apache.org/jira/browse/oodt-691
Repository: oodt
Description
-------
This is a multi-faceted issue and the core issue {OODT-685 Fix OODT
0.7-SNAPSHOT Jenkins nightly build on Ubuntu} IS NOT fixed entirely by this
patch.
This patch does however:
* Set a new directory structure for filemgr component which reflects newer
Maven build and /resources directories as explained in [0]
* Address OODT-688 filemgr jar should not ship with ALL resources, as it sets
filters within the module Maven pom.xml for what we include within the
generated filemgr jar file. This excludes a bunch of junk that was previously
shipping with the jar.
* Addresses OODT-691 by removing the j-globus repository entry within the
pushpull module pom.xml.
* Addresses some javac warnings we were getting by not ensuring type checking
was in place for local variables in a number of places.
It is my intention to step through the review request and address the failing
tests incrementally when I can. The first step is actually addressing the
above... the remainder will come in due course.
[0] https://issues.apache.org/jira/browse/OODT-685
[1] https://issues.apache.org/jira/browse/OODT-688
[2] https://issues.apache.org/jira/browse/OODT-691
Diffs
-----
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/pom.xml 1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/AddProductTypeCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/LocalDataTransferer.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/ingest/CmdLineIngester.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/repository/XMLRepositoryManager.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/exceptions/RepositoryManagerException.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManager.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManagerClient.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/util/GenericFileManagerObjectFactory.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/util/XmlRpcStructFactory.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/util/XmlStructFactory.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/REMOVE.log
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/filemgr.properties
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/MockCatalog.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/MockCatalogFactory.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestLuceneCatalog.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestMappedDataSourceCatalog.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestOrderedDataSourceCatalog.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/UseMockClientCmdLineActionStore.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestAddProductTypeCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestDeleteProductByIdCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestDeleteProductByNameCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestDumpMetadataCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetCurrentTransferCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetCurrentTransfersCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetFilePercentTransferredCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetFirstPageCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetLastPageCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetNextPageCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetNumProductsCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetPrevPageCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetProductByIdCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetProductByNameCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetProductPercentTransferredCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestGetProductTypeByNameCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestHasProductCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestIngestProductCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestLuceneQueryCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/datatransfer/TestInPlaceDataTransferer.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/datatransfer/TestLocalDataTransferer.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/datatransfer/TestS3DataTransferer.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/datatransfer/TestS3DataTransfererFactory.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/ingest/TestCachedIngester.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/ingest/TestLocalCache.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/ingest/TestRmiCache.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/ingest/TestStdIngester.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/metadata/extractors/TestAbstractFilemgrMetExtractor.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/metadata/extractors/TestCoreMetExtractor.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/metadata/extractors/examples/TestDateTimeExpandMetExtractor.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/metadata/extractors/examples/TestFilenameRegexMetExtractor.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/metadata/extractors/examples/TestFinalFileLocationExtractor.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/metadata/extractors/examples/TestMimeTypeExtractor.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/repository/TestXMLRepositoryManager.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/TestProduct.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/TestReference.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/type/TestTypeHandler.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/system/MockXmlRpcFileManagerClient.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/system/TestXmlRpcFileManager.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/system/TestXmlRpcFileManagerClient.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/tools/TestExpImpCatalog.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/tools/TestMetadataBasedProductMover.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/util/TestGenericFileManagerObjectStructFactory.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/util/TestXmlRpcStructFactory.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/util/TestXmlStructFactory.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/validation/TestXMLValidationLayer.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/versioning/TestAcquisitionDateVersioner.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/versioning/TestBasicVersioner.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/versioning/TestConfigurableMetadataBasedFileVersioner.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/versioning/TestDateTimeVersioner.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/versioning/TestDirectoryBasedProductVersioner.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/versioning/TestInPlaceVersioner.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/versioning/TestMetadataBasedFileVersioner.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/versioning/TestProductTypeMetVersioner.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/versioning/TestSingleFileBasicVersioner.java
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/resources/cmd-line-actions.xml
PRE-CREATION
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/resources/cmd-line-options.xml
PRE-CREATION
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/resources/filemgr.properties
PRE-CREATION
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/resources/xmlrpc-struct-factory/product-types.xml
PRE-CREATION
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/ingest/fmpolicy/elements.xml
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/ingest/fmpolicy/product-type-element-map.xml
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/ingest/fmpolicy/product-types.xml
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/ingest/test-file-1.txt
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/ingest/test-file-2.txt
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/ingest/test-file-3.txt
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/ingest/test-file-3.txt.met
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/ingest/test.txt
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/ingest/test.txt.met
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/repomgr/elements.xml
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/repomgr/product-type-element-map.xml
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/repomgr/product-types.xml
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/test.logging.properties
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/test.txt
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/testcat.mapped.sql
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/testcat.ordered.sql
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/testcat.sql
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/testcatalog.typemap.properties
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/vallayer/elements.xml
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/vallayer/product-type-element-map.xml
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/vallayer/product-types.xml
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/xmlrpc-struct-factory/elements.xml
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/xmlrpc-struct-factory/product-type-element-map.xml
1603043
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/testdata/xmlrpc-struct-factory/product-types.xml
1603043
http://svn.apache.org/repos/asf/oodt/trunk/pushpull/pom.xml 1603043
Diff: https://reviews.apache.org/r/22671/diff/
Testing
-------
Tests are broken.
Testing this patch locally will not result in stable build for filemgr or
pushpull.
Testing which can be done includes review if generated filemgr artifact before
and after the patch has been attached to verify that OODT-688 has been
addressed.
Thanks,
Lewis McGibbney
